![]() |
|
1.4.5-dev gallefiffic script doesn't work anymore - Printable Version +- ZenphotoCMS Forum (https://forum.zenphoto.org) +-- Forum: Support (https://forum.zenphoto.org/forum-1.html) +--- Forum: General support (https://forum.zenphoto.org/forum-4.html) +--- Thread: 1.4.5-dev gallefiffic script doesn't work anymore (/thread-11042.html) Pages:
1
2
|
1.4.5-dev gallefiffic script doesn't work anymore - vincent3569 - 2013-05-13 @tplowe56 : 1.4.5-dev gallefiffic script doesn't work anymore - acrylian - 2013-05-13 The problem is still that jCarousel requires it to not confuse normal users. I will not manage the replacement plugin for 1.4.5, even if I would it would not be in 1.4.5 because 1.4.5dev is in feature freeze status already. I agree with sbillard that a plugin is overload for just one line of code. So actually the cleanest would be to either update or throw out all tools that are not compatible anymore. The migrate script logs what is outdated and needs fixing. Maybe take a look, maybe it is just minor things. tinyZenpage was broken as well and is fixed now. There it was just the usage of one now removed function (attr() before, prop() now). 1.4.5-dev gallefiffic script doesn't work anymore - sbillard - 2013-05-13 Vincent: You have missed my point entirely. If this line were relegated to a plugin, then either the user would have to know to enable the plugin (which is unlikely) or the scripts that need it would have to load the plugin. If the latter, which is the only way that you can insure a working theme, then you can just as well load the script as a plugin. 1.4.5-dev gallefiffic script doesn't work anymore - vincent3569 - 2013-05-14 Quote:the scripts that need it would have to load the plugin. adding the line of code needed is centralized somewhere in a plugin, and all objects that need it, force the use of the plugin, don't you think this is a simple way to manage the migration of all the objects that are not compatible with jQuery 1.9.0 (yours and third party ones)? if not, what will I do in my theme? test if Jcarroussel is allowed, if so, I do nothing (the line of code is already added in the header), if not I add the line of code in the header. maybe your themes and plugin are compliant with JQuery 1.9.0 (that is not case with JCaroussel), but are you sure that all popular third party themes have no problem with it? 1.4.5-dev gallefiffic script doesn't work anymore - acrylian - 2013-05-14 A separate plugin does not really help, I agree with sbillard. Because a normal theme user will just see something broken without having clue why. The best would be to make the consolidator plugin a core feature and the recommend way for themes and plugin to load CSS and JS (and somehow ensure the old ways till works to not break older themes). So we can easily prevent multiple loading of CSS and JS scripts. Just to learn form the big ones: On WP that is the recommended way for themes/plugins to avoid the problem we are discussing. It is also possible to de-register scripts if you wish to use your own jQuery and not the included WP one. It is still possible to load things directly on a theme if you wish but clearly not recommended. But adding such a feature and change so close befor a release will not likely happen. Anyway, I will look at the jCarousel plugin these days to see what the migrate script complains about. If it is easy I will just try to fix it for this time. Maybe you should do the same with the gallerffic plugin. Maybe it is just using one old function that can easily be replaced. 1.4.5-dev gallefiffic script doesn't work anymore - vincent3569 - 2013-05-14 I had a look on gallerific issues. in fact, it is the script history, used by Galleriffic, which is inconsistent because it uses .browser(). I don't know how to do that... 1.4.5-dev gallefiffic script doesn't work anymore - acrylian - 2013-05-14 Seems there is no replacement for .browser() and it was deprecated since jQuery 1.3 already. They are following the way not to use browser specific things apparently. I fear beyond my abilities (and time..) to help out, since that is a more complex script, too. So I will look at jcarousel and if we can take out the migrate script there we partly solve the issue of including it several times. jCarousel has already a new one but without backward compatibilty. So I will not work on this and instead do the planned Cycle2 plugin which is a lot more versatile. EDIT: Great, on jCarousel it is also .browser()... 1.4.5-dev gallefiffic script doesn't work anymore - tplowe56 - 2013-05-21 So nothing will be done to fix this? This is the end of the line for zpArdoise? 1.4.5-dev gallefiffic script doesn't work anymore - acrylian - 2013-05-21 jCarousel does not load the jquery migrate plugin anymore, instead we recreate the missing function: https://github.com/zenphoto/zenphoto/commit/467a672f3633b34b50dd64076fe509f85018466a Maybe that can be re-used to fix galleriffic so the migrate plugin is not needed. 1.4.5-dev gallefiffic script doesn't work anymore - vincent3569 - 2013-05-21 @tplowe56 : @acrylian : 1.4.5-dev gallefiffic script doesn't work anymore - acrylian - 2013-05-21 @vincent: Good question regarding double defines. I'll have to ask sbillard who implemented this. 1.4.5-dev gallefiffic script doesn't work anymore - sbillard - 2013-05-21
|