ZenphotoCMS Forum
Commenting Function Bug - Printable Version

+- ZenphotoCMS Forum (https://forum.zenphoto.org)
+-- Forum: Support (https://forum.zenphoto.org/forum-1.html)
+--- Forum: Plugins (https://forum.zenphoto.org/forum-6.html)
+--- Thread: Commenting Function Bug (/thread-13108.html)



Commenting Function Bug - Ralf - 14-07-2018

Hi,
I think I found a small bug in the commenting function:
If you enable the new DSGVO feature "Zustimmung zur Datenverarbeitung" and enable the E-mail notification on new comments no mails will be send.

Without the DSGVO Option enabled emails will be send.

Double checked this with Chrome and Firefox.

Cheers
Ralf




Commenting Function Bug - acrylian - 14-07-2018

Thanks, will take a look. Either a mistake or on purpose but I forgot the reason mile: (Btw it's DSGVO btw or for our English readers GDPR :wink: )




Commenting Function Bug - Ralf - 14-07-2018

Thanks :-)




Commenting Function Bug - acrylian - 16-07-2018

Please try the support build.




Commenting Function Bug - Ralf - 17-07-2018

Hi,
will try it as soon as i have time - probably the coming weekend.
I will give feedback.




Commenting Function Bug - Ralf - 18-07-2018

Hi,
just tested it.
Still no mails send - until I disable the dsgvo feature.




Commenting Function Bug - Ralf - 18-07-2018

Hi,
to make sure that i use the correct updated files:
Can you tell me which files are modified?

I have uploaded classes.php from the zp-core folder and the comment_folder and comment_form.php




Commenting Function Bug - fretzl - 19-07-2018

You can see here what was changed:
https://github.com/zenphoto/zenphoto/commit/169c8a159a75b294367496a7ab60d3aad6bee5a9

FYI: the change works for me.




Commenting Function Bug - acrylian - 19-07-2018

I am sure I told before: Never just use certain files to test even if you know which, always use the complete support build (of course not on a live site and not without a backup!). There always might be dependencies somewhere else that otherwise that throw errors. Not in this case but that's the general rule.




Commenting Function Bug - Ralf - 20-07-2018

Hi,
just re-uploaded the files, emptied the browser cache and now it works.

I think the first attempt fails because of the cache.

Sorry for the confusion.
Ralf




Commenting Function Bug - acrylian - 20-07-2018

Thanks for the follow up!