![]() |
|
problem with function getAlbumURL - Printable Version +- ZenphotoCMS Forum (https://forum.zenphoto.org) +-- Forum: Support (https://forum.zenphoto.org/forum-1.html) +--- Forum: General support (https://forum.zenphoto.org/forum-4.html) +--- Thread: problem with function getAlbumURL (/thread-13597.html) |
problem with function getAlbumURL - ctdlg - 2021-06-18 Hello, There is a bug with the getAlbumURL function in template-functions.php that appear only if :
No problem if Options -> Theme -> Transition is set to "separate" I have removed this code to reach the realalbum in all cases ! ` if (in_context(ZP_IMAGE)) { problem with function getAlbumURL - acrylian - 2021-06-18 I fear I don't understand the issue right now. Especially the "AND you reaach the image from a dynamic album" confuses me. Do you perhaps have link where to see the issue? problem with function getAlbumURL - ctdlg - 2021-06-18 @acrylian Nevertheless, visit this dynamic album: Then choose At the bottom of the image page, a button link " Voir la galerie " The button link from the image page did work if I set There is no "Transition" test in the getAlbumURL function. Problem appears only if you reach an image from a dynamic album. The getAlbumURL function does also work if no subalbum exists in the original album, even if you reach a picture from a dynamic album ! This is why I used "AND" 2 times in my original message. problem with function getAlbumURL - acrylian - 2021-06-18 Since you are using a custom theme, I assume you have tested this with an official theme? This is always important to rule out that a theme does something wrong somehow like setting the images/albums per page manually somewhere bypassing the options. Instead of removing the lines in Anways, we'll have to try to reproduce this. problem with function getAlbumURL - acrylian - 2021-06-19 Haven't had time to reproduce anything but just to note instead of "hacking" core code I recommenend to use problem with function getAlbumURL - ctdlg - 2021-06-20 I have tried with your 1.5.8 basic theme and your template-functions.php file I have only added the button link to image.php file. Voir la galerie I will try your above code with your template-functions.php file. problem with function getAlbumURL - acrylian - 2021-06-20 We still have to investigate this. But the page number calculation apparently misses the "transiton" part of "items per page" here somehow. We will simplify the related default theme options anyway since the concept of "columns" was always a rather awkward workaround and is totally obsolete with especially responsive themes. problem with function getAlbumURL - acrylian - 2021-06-24 I could reprpduce this. The cause were actually neither Fix is up on Github. problem with function getAlbumURL - ctdlg - 2021-06-26 Thank you very much ! |