![]() |
|
Vers.1.6 EXIF bugs and deprecated notice unattended - Printable Version +- ZenphotoCMS Forum (https://forum.zenphoto.org) +-- Forum: Support (https://forum.zenphoto.org/forum-1.html) +--- Forum: General support (https://forum.zenphoto.org/forum-4.html) +--- Thread: Vers.1.6 EXIF bugs and deprecated notice unattended (/thread-13824.html) |
Vers.1.6 EXIF bugs and deprecated notice unattended - Filippo - 21-02-2023 Hi,
Vers.1.6 EXIF bugs and deprecated notice unattended - Filippo - 21-02-2023 To be completely honest, the very first behaviour received for issue 1) was a critical error of "Division by zero" in the value. After my simple injection to transform the $data string variable in a floating value at line 980 of exif.php ($data=(float)$data; //FBO Fix) Vers.1.6 EXIF bugs and deprecated notice unattended - acrylian - 21-02-2023 Please don't mix several topics within one topic/thread in the future.
Vers.1.6 EXIF bugs and deprecated notice unattended - Filippo - 21-02-2023 Thanks for your quick reply. Vers.1.6 EXIF bugs and deprecated notice unattended - acrylian - 21-02-2023 The first was simple so already fixed in 1.6.1a (master on github) now.
Did you do a plain text search? Some functions may be called via filter calls or similar which are not covered if you use a function search via an IDE for example. The usage may also be in the functions.php file of the theme used or some third party plugins. Another possibility is that we missed something in core but then the notices would indicated that.
I don't think so but there are certainly possibly server side caches like APC or OPcache etc that your host may use. Vers.1.6 EXIF bugs and deprecated notice unattended - Filippo - 21-02-2023 Yes I did a plain text search. Thinking that about wrong EXIF data stored in db till 1.6 version, should be a suggestion (as EXIF function are now core of the CMS) to include the update in the Dashboard script "Upgrade metadata" or create a new dedicated script to batch upgrade all EXIF data in one shot. Vers.1.6 EXIF bugs and deprecated notice unattended - acrylian - 21-02-2023 Great. If you find anything deprecated we indeed missed in core files let us know. Best open a ticket on Github (there is already one referring The exif lib was always in ZP core we just moved it to a subfolder in1.6. But is quite old from a time when the nativ PHP exif reading was really bad. At some time we will review to which extend we still need that in this form. Our "Update metadata" actually does update all meta data reading them freshly.
I admit I am not a photographer besides using my mobile so I never noticed. That looks weird and if we store values wrong we of course should fix that. Vers.1.6 EXIF bugs and deprecated notice unattended - Filippo - 21-02-2023 Many thanks |