Great it is working generally now ;-)
Given that you probably have a responsive layout if you have retina support I am not sure the width/height is really needed. I know it is a recommendation for static layout for the browser to see what comes.
It is not really that easy to add this as the function only gets the image urls passed. This would require a new array parameter to several sub function to pass the w/h values for all three sizes.
Best you open another ticket :-)
Hello acrylian.
I post this message after you've closed issue #6
--
Maybe a typo line 545
$croph = getOption('thumb_crop_height', $croph, false);
should be
$croph = setOption('thumb_crop_height', $croph, false);
Maybe should I open a new ticket ?
Yes, that is a typo.
Regarding the albumthumb there is indeed an specific function missing. The idea was actually to use the object model to get the image and pass the object to the imagethumb function. But a proper function seems to make more sense. So yes please open a ticket probably best with a pull request of your change (I probably do it the same way).
Hi Acrylian
First, thanks for making this plugin! Retina support is a must-have for me...
Currently (Nov. 16 2014), your zp_picturefill.php has a parse error: please look at line 358, it needs to be deleted (extra / spurious } )
After I fix this, activate the plugin successfully, and edit my theme to use printHDDefaultSizedImage, I see the following error:
Fatal error: Call to a member function getSizedImage() on a non-object in .../zp_picturefill.php on line 515 (keep in mind this line number is after I deleted line 358)
In my theme, i'm calling your plugin like this:
printHDDefaultSizedImage(getImageTitle());
... I presume this is wrong.
Can you please help?
thanks!
tim
Thanks. The typo should be fixed now.
And yes, you are calling it wrong ;-) Just call printHDDefaultSizedImage() if you are in image context like on image.php(it knows the title already) or within the next_image() loop. Otherwise the first parameter must be an image object.