I will look into that this evening. Does it still apply the settings when the theme is not 'active'? (remember, I'm redirecting iPhone only to this theme in functions.php).
If you find some time, you can always view it in firefox... It just won't be formatted exactly like in iPhone safari.
I have fixed the problem with the custom thumbs in the nighty builds.
It is not so much that your code might or might not have an impact on a standard theme that suggests you should not hack the core. It is that for someone else to use your theme they also must hack the core. They might not be so tallented or attentive to change as you. And, of course, if they do not do it or don't do it correctly, you will be getting the questions of "Why does this not work for me?"
Much better to place the code into the theme where it will always be there.
Also, in tonight's build there will be a new filter for you to use to redirect your theme. attach to the setupTheme filter. It will be passed one parameter--$theme which is the currently selected theme. Simply return your iPhone theme name if the viewer is on an iPhone.
This will not be the place to set the options as option handling setup gets done after the theme is determined.
Thank you gentlemen. This is excellent!
With regards to hacking the core, you make an excellent point that I had not considered. I won't be advising anyone to do that. :)
Perhaps I'm being daft, but I cannot seem to figure out how to set a theme specific image_quality setting anywhere. 'i.php' calls 'functions-basic.php' during the creation of a custom photo, and so it grabs the global image_quality setting, overriding any earlier attempt to non-persistently configure it. Configuring a themeoptions.php file only serves to change the global settings for image_quality.
Regardless, this is not a major requirement. I think that one global setting should be sufficient for most.
I've finished putting together the project page for the theme. I'd be honored if you would consider displaying it in your theme gallery. Thanks for your amazing application!
Great, I will take a look and then add the theme to our themes page later.
Regarding the image quality: You can also use i.php directly to generate images instead of using the custom image functions or class methods. These are acually wrappers. Then you can set the quality parameter directly.
To anyone who is interested, I've posted an update to this theme with some fixes and improvements.
Actually, i.php will grab the options from the current theme which may be an album theme. Maybe it does not pick up the theme returned from the filter. When I get back from vacation I can check into that.
But it certainly will not pick up a temporary option as it is a new run of the script, so I guess you will have to deal with that and cause the quality to be selected at the call on the custom image functions.
That doesn't work, because it ends up collecting the global setting for the currently selected theme. The only way I've found to work (posted above) involved editing the core, which I'm not going to recommend to anyone :)
This isn't a big deal. I think everyone is fine with one global setting for image quality. I certainly am.
And build 4475 will isolate options by themes as well as by albums. So you could acutally just set the options the way you want for your iPhone theme. The only drawback is that you will have to set your gallery theme to the iPhone theme while you are setting up the options. Then set it back to whatever you want.
This is really a great piece of work - thanks a lot. Have you thought of using jQuery/jQTouch to make it even look more iPhone-ized? I have started looking at it and made a small theme, but I am not familiar with Ajax, so there is little point for me to personally go down this route on my own...
The theme installed successfully, but no images thumbnails appear in the album view. If I manually type in a specific image's url, the image.php works properly, but album.php doesn't seem to be generating any thumbnails or links... anyone know what might be causing this?
Loaded this theme and changed /zp-core/function.php as noted in the install instructions to make the them work only on iphone browsers. The theme loads just fine and the browser id works great. Only problem is that when I his gallery view I see the same 6 or 7 albums, it never shows me the others. Fix for this?
Also, could it have a search box? My pics are mostly tagged and it would be very helpful.
Great theme, thanks for the effort and time you have put into it.
Thanks guys for the excellent forum. Very helpful for guys like me who are new to php and zenphoto. The iPhone theme works great after a little tweaking due to some older functions being used. I have enabled the support for mobile or non mobile theme based on the browser by updating the functions.php (it's a patchwork, not a good solution) but it seems to be working fine. Now I would like to use some video streaming support (like xmoovStream) to stream flv or mp4 video, and switching the video source based on browser (flv with Flash for Windows/Linux, mp4 with QuickTime for Mac/iPhone/mobile browser). Has anybody done any work on this?
Not that I know but that is surely possible with a plugin.
Also, if you have updated the theme and maybe wish to maintain it for the future let us know. Please see the theme section on our "contributor guidelines" on the user guide for info how to provide third party themes so that we can include them on the themes section.
I would be happy to provide the minor updates I made to the iPhone theme. Please note that this is not an original theme, I have made two types of modifications:
The original theme is available at http://code.google.com/p/zenphotoiphone/. I am not sure whether to contact the creator of the theme to include my updates or to add as new theme. It seems the original theme has not been updated since 9/11/2009.