Member
Member
frankm   17-05-2010, 05:51
#1

hi,

this is to report an inconsistency i guess.
when using the function printZenpageRSSHeaderLink("News", gettext('News RSS') );, we should get "News RSS". but we always get "zenphoto/rss-news.php?lang=en_US" (or whatever your language is at the end).

looking at the template-functions.php file for the zenpage extension i found that theprintZenpageRSSHeaderLink function call the getZenpageRSSHeaderLink function with only 2 arguments ($option and $linktext) where the getZenpageRSSHeaderLink expects at least 3 arguments ($option, $categorylink and $linktext). i think the printZenpageRSSHeaderLink should slightly be modified to match the number and order of the arguments.

cheers,
frank.

Administrator
Administrator
acrylian   17-05-2010, 09:50
#2

I agree about the parameters. I don't remember why we have the $linktext parameter here anyway, probably an oversite. Actually the linktext parameter is usesless as the header link will never have a actual visible link printed.

I guess the link text should be used with the "title" attribute if it should be used at all.

Administrator
Administrator
acrylian   17-05-2010, 16:56
#3

I took another look and $linktext is used for the title attribute. Therefore everything is as it is meant to be. printZenpageRSSHeaderLink() indeed calls the get variant wrong. This will be fixed in tonight's nightly build. Also I will add a $category and $lang parameter to the print one, although in a different order to not break third party themes.

  
Powered By MyBB, © 2002-2026 MyBB Group.
Made with by Curves UI.