Should I post this in Bug Tracker?

http://www.thrustimages.com/

I have turned on Grayscale Thumbnails in the Theme Options page. Some Thumbnails REFUSE to generate in grayscale. I have manually deleted the cache, regenerated the cache from the admin page, allowed ZP to do it upon a user viewing a page. Some thumbs simply refuse to gen in grayscale :-(

As an example, please see my web site above. The Floyd Bennett Field album is one example, it's album thumb is always in color and then in the gallery itself, the Capital Airshow gal for example, one image thumb refuses to generate in grayscale.

Thanks for your help.

Manny

Yes, please post this in the Tracker. But be sure to attach sample images that do not grayscale. Off the top of my head I see no way that there can be any difference in handling, though.

I did examine your link above. Curiously, the thumbs that are not grayscale are being fetched from the cache while the ones that are grayscale are generated by i.php. This latter is pretty strange since after a page refresh these should all be cached and there sould be no links involving i.php.

Are you perchance using custom image functions for your thumbnails? Further investigation shows that the cache name of the image should have "_gray" appended to it if it is grayscale. Neither of those two cached images did.

I suspect that there are two things happening.

1. Somewhere in your theme there is a standard "thumb" being generated for those images.
2. The code that is generating the inline thumbnails is not perserving the "grayscale" request when it gets the cachefile name so that it will "find" the regular version of the image when it looks in the cache if there is one. If not it will generate the i.php call (which will create the thumbnail with the requisite '_gray' tagging and will not therefore be found for the request without the grayscale indicator.)

There is a means to collect data about what is going on. Set the `DEBUG_IMAGE` define in functions-basic.php to `true` and all sorts of data will be collected in the debug log.

I am pretty sure the zpGallerific theme uses custom image functions for layout reasons (think its author mentioned that somewhere on the forum on some image size topic).

Hey guys, thank you for your prompt reply. I will post more data as I collect it. I will also post in bug tracker for you ;-)

For now, here is what I have done to the stock gallery

--Installed latest ZP
--Installed zpGallerific theme
--Modified the custom.css file only
--Modified some of the theme images.
--Switched some of the colorbox images in the zp-core folders

That's all I can remember. I have tested by totally deleting the cache folders, regenerating the caches from admin, purging the cache from admin etc. It only happens in some galleries, and even WITHIN a gallery, some images are grayscale and some are not

I can give you guys FTP access to my site if you wish to peruse any of the files, folders etc. Let me know off-line. manny (at) manny (dot) org

Cheers!

OK, turned on debug. At first it was causing errors in all my pages ??? it reported the problem on the last line of functions-basic.php. I looked and it was just a CR->LF I removed them and re-uploaded. Oddly enough, that fixed this problem.

Now, the Debug.log is huge, what do you want me to look for? If you want to look at it yourselves, let me know.

Posting to bug tracker now.

Thanks

First note that zpGalleriffic is a third party theme we therefore can't support as we don't know what is does.

Did you check if that theme uses custom image functions as my collegue mentioned? Those can override the admin options and need a separate parameter set manually. Info about those functions on our user guide's documentation.

If you haven't please test if this issue occurs with a standard theme as well.

Don't forget to clear the image cache.

OK, I understand of course. Le t me test with a default theme. BRB.

Default Theme is working fine. ZenPage is broken (not sure why) and Effervescence is fine.

I switched on each of the default themes. Purged the cache each time. All thumbs being generated in greyscale

Eventually I put back the zpGalleriffic theme and now all thumbs are being generated with greyscale. ???

Could it be the actual thumbnail greyscale checkbox setting? I noticed when I switch from zpGalleriffic to the default hteme, i have set this option again. As if the setting was not exactrly the same.

I'll keep an eye on it and report back as needed. Thanks for your help!
Manny

[i]ZenPage is broken (not sure why)[/i]
Well, that theme uses the custom image functions as said above which don't honor the greyscale setting. I assume zpGalleriffic does it the same way.

If Zenphoto finds a cached thumb images at the same size it will use it without regenerating it. Maybe that was what you encounter when switching.

EDIT:
Just tried the Zenpage theme on my local test install and even with the custom functions I did not spot any thumb that was not grey scale generated so far.

We will need to look at the debug log. But we can "limit" the data somewhat. Get the page with the problems up in a browser window and the admin/logs tab up in another window.

Reset the debug log then refresh the other window. Without doing anything more capture the debug log and attach it to your ticked.

We'll do ;-)

@acrylian, My Zenpage theme is broken in that I have no Gallery link. I am sure it is a mistake on my part, not the theme. Likely one of the settings is wrong. Not a big deal.

I am sorry I pasted output into the ticket. Don't know how to delete it. Feel free to yank that post.

I uploaded a copy of the debug log.

Think I see a pattern. If I load any of the default themes and set the thumbnails to greyscale, change back to ZPGALLERIFFIC, all works fine. To revert back to color thumbs, I do the same thing. Works fine IF I first enable the feature on a default theme. IF I do it ONLY in zpgalleriffic, it does not work consistently. Sometimes some images get grey some do not.

Right now, I have it set as I did originally which is to ONLY activate grey thumbs in zpgalleriffic. It is again not consistent, but, the pattern has changed. Some galleries that did not work before are working now, and yet some that did work, are not working now.

I know how to work around it which is good enough for me, but if it is a bug and I can help, feel free to ask me for anything, including FTP to my site

Thanks
Cheers!

You are in good company. None of us know how to edit comments in tickets once they are posted! Anyway, this it either a bug or not depending. The function you are using defaults the grayscale setting to off. It probably should not, though. In the ticket I have posted a work-around. We will change the behavior of the function in the next release.