Home› Plugins

sitemap-extended goes blank

tunafish Member
in Plugins
When I click the Generate sitemaps button in the admin I get a blank page..
My PHP log says:

Call to undefined function printSitemapGoogleImageVideoExtras()

Any idea what this could be?

I have seo_locale plugin active and mod_rewrite works.
I DO have a custom home page though..

EDIT: That's odd I did a search/scan for the `printSitemapGoogleImageVideoExtras` function in it looks like the function does not exist??

Comments

  • acrylian Administrator, Developer
    Seems to be a typo or the "print" version got lost somehow as there is somehow indeed only a "get" version currently. Will take a look tomorrow.
  • tunafish Member
    OK acrylian, it was just a quick question just before going to sleep.
    I changed
    `printSitemapGoogleImageVideoExtras(1,$loop_index,$albumobj,$images);`
    with
    `$data .= getSitemapGoogleImageVideoExtras(1,$loop_index,$albumobj,$images);`
    and all was good :-)

    I have 2 more questions though:

    - on Google Webmaster Tools I added the URL /index.php?sitemap
    But I guess I need a cronjob to trigger sitemap updates am I right? Is there any other way to access the sitemap creation outside ZP's admin? I mean if there are any updates the sitemap somehow needs to reflect that and pusshing the button every time is prone to be forgotten..

    - After finding the typo I copied the `sitemap-extended` folder and `sitemap-extended.php` file over from /zp-core/zp-extensions/ to /plugins/ to make the correction.
    On the admin zp-core/admin-plugins.php I saw the plugin listed with the ZP icon (new in 1.4.2)
    I thought that the icon ment to plugin is scoped from the zp-extensions/ directory but to my surprise it loaded the corrected version from the plugins/ dir.

    So my question here is.. which one takes precedence? The one from the plugins/ dir?
    When I am upgrading ZP I can just override zp-extensions/ dir with the default extensions? I don't need to delete them? But what about the icon? A bit confusing.. it should be clearly defined in zp-core/admin-plugins.php if the plugin/extension is ZP or custom I think.
  • acrylian Administrator, Developer
    1) Yes, index.php?sitemap is the url to use. You can also add the site map url in your robots.txt file so search engines find it more easily.

    No, the site map is only generated on admin request. The former way was that it could update the cached files automatically (like the static_html_cache can). But it appeared that this might overload some sites/servers especially if the googleiamgealbum addition is enabled. Then on sites with lots of images quite huge lists are generated. We therefore choose to change that.

    2) The "zp icon" does not mean "new", it means actually "officially included plugin" (any plugin author now can choose its own icon for 3rd party plugins and also themes).

    Generally you should not have two plugins of the same name, no matter where, you should at least rename it to sitemap-extended-custom. You probably confused Zenphoto. I don't think there is an order for that case (it is for special plugins that can have custom user stuff like a comment_form within /plugins or a theme, then the custom stuff gets priority).

    Best is you remove the custom one, then the official and then re-enable your custom one. Note that you cannot move all plugins from zp-extensions to plugins as some have code paths that will not work without a change.
  • acrylian Administrator, Developer
    Bug will be fixed in tonight's nightly build.
  • sbillard Member
    If you have a user plugin of the same name as a zenphoto one you will indeed get a "mixed" set of code. The base plugin will be the zenphoto official one. But files loaded by the plugin with `getPlugin()` will come from the user plugin folder if they exist there.

    This latter is done so that things like custom forms and css can be placed in the user version of the folder to override the officially provided files.
  • nbruley Member
    I got this same error after adding the SEO_locale plugin. Is that a different issue?

    Thanks.
  • acrylian Administrator, Developer
    If you are not on 1.4.2.2 probably.
  • nbruley Member
    Looks like you're right. When I click the link "see changes on trac" I'm confused where to go to see the changes made in 1.4.2.2

    Thanks.
  • acrylian Administrator, Developer
    The changes are on the "timeline". At the time of the release you just need to go backwards to see all previous changes. Now we are of course a little further as we are heading to 1.4.2.3. ALso those changes are for both streams, 1.4.2 trunk and 1.4.3 dev.

    The easiest to see the changes is to use an svn client.
Sign In or Register to comment.