search form ZP 1.4.2 - issue when refining

frankm

hi,

i have just upgraded to ZP 1.4.2 on my development server and i'm running some test before going live.

there is something weird with the search form.
if we do one search, we get the results and the reset icon is shown. the title attribute of the search button is changed to '... within previous results'

now if by mistake we hit the search button without entering a new search word, no results is return. looking at the submit javascript function it should actually repeat the initial search and return the exact same results.

i think line 3978 of the template_functions.php file is not correct. it reads
`$('#search_input').val(<?php echo $searchwords; ?>);` but i think it should read
`$('#search_input').val('<?php echo $searchwords; ?>');`

the `<?php echo $searchwords;?>` should be in between simple quotes.

frankm

frankm

actually i am not sure the refining search is working properly.
if i do a first search on 'burma' and refine it with 'buddha' the results are only on 'buddha' and not '(burma) AND (buddha)' as the submit javascript function suggests it should.

i wonder if line 3977 of template_functions.php should read
`$('#search_input').val('(<?php echo $searchwords; ?>) AND ('+newsearch+')');`
instead of
`$('#search_input').val('('+<?php echo $searchwords; ?>+') AND ('+newsearch+')');`

frank

acrylian

Note that the current release is 1.4.2.2.

frankm

actually that the one i am installing. here is the complete reference:
zenphoto version 1.4.2.2 [9365] (Official Build)

acrylian

Well, the full version is an important bit of info… I am not sure about these lines. My colleague will know.

sbillard

Those lines have been corrected at least in the nightly build.

frankm

i should have gone for the nightly build then thanks.