Home› General support

1.4.6: Number of thumbs in combined mode is wrong

Wete Member
in General support
1.4.6 Final
self-made Theme
Albums: Thumbs per row: 4, Thumbs per page: 12
Images: Thumbs per row: 4, Thumbs per page: 12
[x] combined mode

Works fine if there are only albums OR Images in an album, does not work, if there are albums AND images. See here:

http://www.musikverein-zunsweier.de/galerie/rpk2009/

There should be 3 rows of thumbs (first row with 3 albums, second and third row with 4 images). Worked fine until 1.4.6. I did correct the deprecated funktions but nothin else in my album.php/search.php

Regards!
Wet

Comments

  • acrylian Administrator, Developer
    Depeneds actually on your theme css. Both loops are wrapped within their own div elements.
    Combined means albums and images on one page, not the same row. Separate means separate pages for each (first album, then images).
  • Wete Member
    I know what's the difference between combined mode and separate.

    The complete number of thumbs on a page should be 12 (or less if the number of albums is not divisible by 4). There should never be a forth row of thumbs (as it is in my example). This behaviour is new since I upgrated to 1.4.6

    In my opinion, zenphoto calculates the number of image thumbs wrong if there are sub-albums.

    Wete
  • acrylian Administrator, Developer
    Ah, okay, I see what you mean. But I think that does not work because there are only two albums. Did you try a standard theme just to exclude it is something on your theme? You technically can set those "per page" options manually and independently, too.
  • Wete Member
    As I wrote: It worked perfectly until 1.4.6.
  • Wete Member
    It's the same behaviour in "Basic" Theme: The definition of "thumbs per row" and "thumbs per page" results in a number of maximum rows per page. In my example (4 each row, 12 each page) it results in 3 rows per page.

    Now it seems that the number of rows for sub-albums is not subtracted from the maximum number of rows - and this worked excellent in < 1.4.6!

    Example: An album with 3 sub-albums and many images. Settings: 4 thumbs per row, 12 thumps per page. For albums and images.

    Zenphoto < 1.4.6:

    [A] [A] [A]
    [I] [I] [I] [I]
    [I] [I] [I] [I]

    Zenphoto 1.4.6:

    [A] [A] [A]
    [I] [I] [I] [I]
    [I] [I] [I] [I]
    [I] [I] [I] [I]

    Wete
  • acrylian Administrator, Developer
    Ok, I see what you mean. Best you open a ticket pointing here.
  • Wete Member
    OK, but I have to study the bug reporting system ... this could take some days!
  • acrylian Administrator, Developer
    It's pretty simple. You open a free GitHub account first and just create a ticket on the issue trakcer link on top of the site here. Not more complicated than posting here.

    It might take some tiem to fix this, too, although probably a small thing. As you might have noticed there are some other things right now…
  • trisweb Administrator
    Thank you for the report! Please open a ticket here when you are able to log in to GitHub: https://github.com/zenphoto/zenphoto/issues
  • acrylian Administrator, Developer
    I tried it in hte basci theme. There you can only have two albums per row as of the theme layout.

    And setting four thumbs per row does not work as the default thumbs are too small so they are always five.

    But I see the general issue indeed. I am not sure if that is the actual behaviour. I have to admit I rarely use albums that way when doing custom themes. I mostly have either albums or thumbs so I never really noticed. Nevertheless please open a ticket.
Sign In or Register to comment.