Can't edit and re-name image files after upgrade to 1.4.6

Archbob

When I try to rename the files in the admin and put in new Metadata after I upgraded to 1.4.6, I get:

Notice: Bad filename suffix in newImage() in /home/goodfree/public_html/zp-core/class-image.php on line 73

Notice: Bad filename suffix in newImage() in /home/goodfree/public_html/zp-core/class-image.php on line 73

Notice: Bad filename suffix in newImage() in /home/goodfree/public_html/zp-core/class-image.php on line 73

Warning: Cannot modify header information - headers already sent by (output started at /home/goodfree/public_html/zp-core/class-image.php:73) in /home/goodfree/public_html/zp-core/admin-edit.php on line 447

Didn't happen in 1.4.5.9

Has this happened to anyone and have you found a workaround?

Archbob

Also I noticed every time I try to navigate within the admin panel, I get a "are you sure you want to leave this page" popup. That was never there before.

The Admin Panel seems really really slow now(its been slow for a while to load). Seems like when I want to edit images, it takes years to load.

acrylian

1. So from the start what did you do exactly?

2. Regarding the slow backend: Have you rules out the things mentioned here? http://www.zenphoto.org/news/problems-with-albums-and-images
It is most likely too big images plus possibly random album thumbs.

Archbob

From the start I uploaded the photos and then there is a link at the bottom of each photo that says "Edit all image data" which takes me to a new page to edit each individual picture. I rename the file and put in all the Metadata and when I hit submit the errors show up.

Its kind of weird because the changes actually go through.

Also if a category has more than 10 images, clicking on the edit button just takes me to an album edit page and not an image edit page.

There seems to be a lot of things that basically don't really work in admin after the upgrade to 1.4.6. You guys seemed to have changed the way editing images within albums works.

Archbob

I do use 3371x2271 images but I have 4GB free memory on the server with a quad core so it shouldn't be a problem. After the 1.4.6 upgrade, it got a lot flower for some reason.

It was slow but you could work with it in 1.4.5.9 but now it functions differently and doesn't really work.

acrylian

Also if a category has more than 10 images, clicking on the edit button just takes me to an album edit page and not an image edit page.
I am not sure I understand. Which edit button you mean exactly? From the album list (http://www.zenphoto.org/screenshots/zenphoto-admin/gallery.jpg.html) you get first to the album edit page (http://www.zenphoto.org/screenshots/zenphoto-admin/album.jpg.html) and only if you click on the icon with the image number on the right you get to the images edit page (http://www.zenphoto.org/screenshots/zenphoto-admin/images-editing.jpg.html) directly. That actually has not changed.

Regarding the renaming you might need to rename the image first since that happens on the file system and then edit meta data. That might be a bug with renaming the file and editing the data together. I will try to reproduce that.

Archbob

Its once I'm in the album and there a list of images to edit, there's ten images that it lists per page. The 1st ten work, the rest don't, it just takes me back to the images list on the album.

If I just try to rename the file without hitting "edit all image data", the changes don't go through.

Basically editing images does not work at all after the upgrade, it worked fine in 1.4.5.9.

What did you guys change? I looked through the changelog and couldn't find anything critical.

acrylian

Image editing tab: To my knowledge nothing significantly has been changed. I am also not able to reproduce the issue with the general image editing pages. I tried on our site with 147 images in the showcase album and all works fine.

You can try to lower the number of images per page as that might be the old issue with too many form elements to post. But I would wonder about that since what you get via "Edit all image data" is now calling a new page instead being just hidden via JS as on 1.4.5.9 for exact this reason.

But I now understand what you mean with being slow. Strangely to me only the title field, the main content field is fast as ever for me. I can only assume that the script that checks for the form changes is causing that. That is the only thing new besides that. And that would be a case of too many form elements as well.

Update: Interestingly I cannt reproduce the slowliness on my local server. Probably the number of tags makes a difference as any entry is a form element, too.

Archbob

Where in the admin panel is the option to lower the images per page and where does this error:

Notice: Bad filename suffix in newImage() in /home/goodfree/public_html/zp-core/class-image.php on line 73

Notice: Bad filename suffix in newImage() in /home/goodfree/public_html/zp-core/class-image.php on line 73

Notice: Bad filename suffix in newImage() in /home/goodfree/public_html/zp-core/class-image.php on line 73

Warning: Cannot modify header information - headers already sent by (output started at /home/goodfree/public_html/zp-core/class-image.php:73) in /home/goodfree/public_html/zp-core/admin-edit.php on line 447

Come from when I try to edit via the "Edit all image fields"?

I have a feeling these are linked.

As for reproducing the error, if you have more images in an album that can fit on a page listing, go to page 2 and click on the "Edit all Image data". Page 1 works fine, but trying to edit the images on page 2 doesn't work for me.

acrylian

I neither get those errors on zenphoto.org nor my local server. I did a quick test what slows down the images editing is the list of the tags especially if you have 100+ tags. The form change check script it is not.

Originally we wanted to place them on "Edit all image fields" but felt that they need quick access. However there is of course the bulk action for it, too. That can be changed.

I am not sure I understand the "Edit all images data" and the page 2 issue. If you click on that you get one page for the image you clicked on it. There are not supposed to be more pages to click through at all (regardless that there is a pagination at the bottom).

acrylian

What is that for an image that throws the error. Normally the bad filename suffix is a graphic libary issue on the server lacking support if I recall right. Would be strange though I guess.

Archbob

What graphic library is needed for Zenphoto in this version. If there is over 100 tags on the list, it slows down? I write tags for every image, I think its because I though commas separated the tags but they don't is why I have so many tags.
Be nice if tags only showed up on the "edit all image data" page.

The page 2 issue is each album lists 10 images per page then there's the pagination for page 2,3,4 etc. Click on page 2 of the images and try "edit all image data" link, it doesn't work.

acrylian

What graphic library is needed for Zenphoto in this version.
Same as ever GD 2.x or Imagick 3.0.0+ and ImageMagick 6.3.8+

If there is over 100 tags on the list, it slows down?
Number is an example. The only difference to my local test site and zp.org is that zp.org has many more tags. If you have in total 50 tags (not important if assigned) you have 50 form elements per images and if you have 10 images per page you got 500. Posting them all can surely overload but is rarely the case. I can only assume the form check js that checks all form elements is involved. However removing the tags selection list did speed up things, not removing the script. So I will do that in the master soon and you can retry if that speeds things up again.

The page 2 issue is
Ah, now I finally got it and I can reproduce it, too. Good that already have a ticket.

Archbob

let me know when this gets resolved and what files, I would really like the edits to work. I check at the libraries for GD and Imagemagik, although its strange that they worked in 1.4.5.9 and now don't work in 1.4.6.

acrylian

You can see the changes on GitHub at any time. Click on the "xxx commits" link on the Zenphoto repo. You should download the whole package. Individual files might be possible but as a general rule not recommended. Generally much changed from 1.4.6 generally and what did is bugfixes.

To my best knowledge no requirement regarding the graphics libary requirement changed since 1.4.5. All working here as ever including standard shared hosting. Your error could be related to a failed image filename change, too.

Archbob

We just installed the latest version of GD and Imagemagik and it still gives errors at line 73, not sure why.

I honestly preferred the dropdown on the meta fields to this editing in a new page. It was quicker and easier.

acrylian

That dropdown was causing the said too many form elements so nothing was posted if you submit. They were just hidden and not loaded on clicking. It made it unusable on my own shared host for example. Keep in mind also that Zenphoto is targeted at such normal shared hosting usage where you cannot raise such values. And my shared host is even pretty good setup actually for these things.

These are all things can be done differently with our planned changes and your feedback is very valuable and welcome. But as you can imagine since we want to do some general UI changes and those properly that might take quite a while. So for now we sadly have to live with some compromises.

Archbob

I understand that.
I was just hoping for a bug fix on the line 73 error and also being able to edit all the photos on the separate page. Right now I am doing them manually(the metadata) in mysql.

If you have any plans for a paid product with more premium support at a subscription price(say $25 per month) that would be targetted towards larger sites like large galleries or repositories with more theme fitting for that kind of thing, let me know, I would be interested in subscribing

Also another error in 1.4.6 is that when you edit the several images(not in the separate page), like changing their filename, tags, at a time just from the editing images within the album, the changes don't go through. It only works if you edit them one at a time.

acrylian

The problem is to fix a bug like your image suffix one we need to be able to reproduce it. So far I couldn't. Maybe someone else does and has any idea.

Zenphoto should of course work on all kind of sites. I will see to get the image edit page faster by moving the tags selector to the "all image data" extra page and try to fix that "all image data" link issue sometime the next days. More I cannot do at the moment.

I would refuse any significant backend changes before we are clear what we do how to avoid unnecessary double work. All in very early states and it must be doable without breaking everything. That's why feedback like yours is very welcome and helps us to collect what can be done better then.

There are no plans for any premium service (I personally certainly do paid support). That would be one step before the other anyway right now anyway. I think our support here is actually quite premium given our number and not doing this as a main job ;-)

Archbob

Well, the image extension I use is just the default .jpg and even if I don't change anything in the Separate page edit for "Edit all Metadata" and just hit apply, it still brings me that error so I'm completely lost.

My filesname I rename to are like "michigan-state-park-lake-and-clouds.jpg" . It works ok if I just edit the truncated edit from the albums(only if I do one image at once though) but does not work if I go to the "Edit all Metadata" page.

acrylian

Just certain images or all? Did you check with another image? We have seen issues with corrupt meta data embedded before. If you can link to an image directly (here or on a ticket) so we can try with on of yours.

fretzl

I just opened two tickets on GitHub which I believe are related to these issues.

Archbob

It only goes through if you edit one image at a time, doesn't work if you want change multiple images.

acrylian

I still strongely suspect that is the form element limit on your server I talked about. Though there should be errors about that. Have you tried setting it to 5 images per page?

acrylian

So the "edit all images button" should now work from all image edit pages. Also I moved the tag selector to the single image page only. Please try if that solves the speed issues as a quick fix.

I finally could reproduce the bad image uffix error but I have no fix yet. That might take longer to fix.