We need some testers!

Want to help out with development?

I've recently done a lot of development and need some people to test the current SVN code. If you're interested, go ahead and check out a copy and install it wherever you can.

Changes include:
- mod_rewrite for sub albums (if using the sub-albums theme)
- Faster (direct) image loading for cached images
- A LOT of code changes, refactoring, moving things around...

To check it out, do `svn export http://www.zenphoto.org/svn/trunk` at a command line where you have svn installed, or through TortoiseSVN or whatever you like. Installation/upgrade is as normal. No need to run upgrade.php from 1.0.7.

I don't recommend you use this for a production gallery yet, but I'm running it on http://www.trisweb.com/photos and it seems to be working fine.
«1

Comments

  • Using TortoiseSVN I get the following errors with this new SVN:

    ERROR: PROPFIND request failed on '/trac/browser/trunk'
    ERROR: PROPFIND of '/trac/browser/trunk': 200 OK (http://www.zenphoto.org)

    I did manually get the files and am using them, although I am not using the new testing theme.
  • Excellent. I am now using the SVN for my http://www.bushwoodworking.com/zenphoto gallery. It is working well, except for mod_rewrite and display of image thumbnails. If I turn mod_rewrite on, I get the "image not found" (nice new photo placeholder BTW) on some images. what i noticed is that if I toggle mod rewrite off and tried those same ones, they displayed, and then if i toggled mod_rewrite back on, they were cached this time, and seemed to work (although not all of the images in all the galleries worked, if they weren't cached in a non-rewrite environment). The random image display function doesn't display correctly under mod_rewrite either. The links look to be OK, it just isn't caching the thumbs properly. And a big note, these seem to be specifically subalbum thumbs. The regular album thumbs seem to work OK.

    I left the mod-rewrite on so you could see it.

    Let me know if there is stuff I can try for you. I have a good backup. :)

    So you know, it's SVN rev 345, with the modified Effervescence theme being used. I wanted to test out the theme and really see if I could break it. :)
  • I will test this one and post my comment tonight. thanks!
  • trisweb Administrator
    @Craig, could you please upgrade to the latest revision (346) of functions.php and i.php (changes here)? I've added some more debugging output that should help test this problem...

    It's probably not your theme; as long as it's forming its image URLs properly then it's most likely a problem in i.php.
  • trisweb Administrator
    @aitf311 - looks like you tried to checkout at the Trac SVN viewer address ;-) (`http://www.zenphoto.org/trac/browser/trunk` is the trac viewer, but `http://www.zenphoto.org/svn/trunk` is the SVN path). Tortoise is working great for me, it's what I use every day for working with the repo.
  • Thanks tris, updated to 347

    Some images do not show even though their thumbs are:
    removed
    This image is in a subalbum
  • trisweb Administrator
    Whoopsie, I really should test before committing. Try the latest, rev. 348.

    On a side note, the reason some of your images still show up is because Zenphoto now skips i.php completely if there's a pre-cached file, avoiding the costly and redundant double-request to the server for each image. It still checks file modification times and such to see if updates are needed.
  • OK. Updated to SVN rev 348, and still the same thumb issue with me. What kind of debugging output should I look for from i.php?

    Craig.
  • Tris, this has fixed my error.
  • trisweb Administrator
    @Craig - I was hoping the new revision *would* give me the debugging info, but I made a mistake. I'll let you know when the update is complete. You can roll back before then if you need the gallery to work...
  • I'll be sure to test it when I get my computer back -- it's getting fixed.
  • Exciting! Hooray pretty subalbums :D

    Wasn't sure to what extent you wanted admin interface suggestions/observations since subalbum options didn't appear to be implemented in the build I exported, so here's what (little) I noticed outside of that:

    - Album descriptions for thin images (i'm guessing less than 50% width) appear to the right of the image instead of underneath in the default sub-albums theme. Probably a quick fix with a div or p/br.

    - I had an initial blip (I didn't have perms set correctly for the cache dir) where when I drill down to a single image, the "next" link points to the parent album (w/o pagination) and there is no "previous" link visible. It's the same regardless if the image is the first, second, or last in the set. Blip though, because I can't seem to recreate the problem with subsequent albums and all manner of permissions-changing directory-moving futzing that I could think of, but I thought i'd mention it in case anyone else comes across the same issue.

    Outside of those two issues, everything seems to be working very smoothly :) Albums navigate as you'd expect, URLs are pretty... it just works ;) Great stuff!
  • @trisweb-

    No worries. None of my galleries are production quality, so if they are missing some images, that's ok. remember that if I turn off mod_rewrite, everything works OK, so i'll stay with rev 348 until you update. Besides, it'll give me chance to try the next rev of SVN when you have it done.

    :)
  • trisweb Administrator
    Next revision is up and should give us better (and safely XSS-attack-proof) debugging info that we can use for all ZP installs from now on.

    Just place `?debug` or (`&debug` if there are already query variables) after the i.php (or mod_rewritten i.php) requested image path like so:
    `http://www.bushwoodworking.com/zenphoto/zen/i.php?a=homeimprovements/cornerroom&i=home_frontelev.jpg&w=180&cw=180&ch=80&debug`
    Once craig updates, we should see some useful debug information there, or an image if it starts working.
  • OK. Got it updated to rev 349. You may fire when ready.

    I get worse results this time with images, but hey, we're testing, right?

    :)
  • And I get:

    `Zenphoto error: Image not found!

    Cache: [ /cache/zen/i.php_w180_cw180_ch80.jpg ]

    Image: [ zen/i.php ]`

    With the image you pointed to above after upgrading.
  • And just for grins, I turned mod rewrite off and on again. I refreshed the page once with mod rewrite off, and it cached a few thumbs on the front page (as long as they are cached, they display properly - but you have to turn off mod_rewrite to get them cached...)

    Looks like it's specific to mod_rewrite and caching of thumbnails but what is causing it I have no idea. (I know I'm pointing out the obvious here...)

    Mod_rewrite is currently on.

    :)
  • i am now running it on my test site and the only error i get is that some images cannot be found.
  • trisweb Administrator
    @Daxeno, you're having the same problem as Craig: this is the debug message...

    `Zenphoto error: Image not found!

    Cache: [ /cache/zen/i.php_w190_cw120_ch85.jpg ]

    Image: [ zen/i.php ]`

    (as long as you don't cache that image, you can see it here)

    Looks like the way I'm trying to fix the album path for mod_rewrite bugs (essentially, getting the mod_rewrite URL string and manually extracting the album and image) isn't working as I expected. I'll be releasing more versions for you guys to test in the very near future...
  • Cool. Let me know as you have versions you need tested and I'll put them up as soon as possible.
  • trisweb Administrator
    I figured it out, new version in SVN should work. Let me know!

    Also, for those of you interested in some thumbnail sharpening, add the following line to your zp-config.php:

    `$conf['thumb_sharpen'] = true;`

    :-)
  • trisweb Administrator
    Hold on, still working on it...
  • trisweb Administrator
    Fixed! Give it a shot. All images requested with mod_rewrite-style paths or not, with mod_rewrite on or off should work now :-) We're up to revision 359.
  • Rev 359 fixed my cache dir issue and sharpened thumbs are working great :) Initially I added the thumb_sharpen line to the top of zp-config.php before I noticed you had an existing one set to false further down in the file.

    I believe the previous issues I mentioned in regards to the previous/next entries getting a bit fubar'd are the same as this issue. In my case I was changing around and renaming albums and files, but the garbage collection doesn't seem to be finding the orphaned entries (or maybe i'm misunderstanding what it should do?). For example, if I completely clear out the albums and cache subdirs and click on the admin refresh option, it's currently showing it has 107 images in 9 albums. The quick fix for me seemed to be to manually drop and recreate the database.

    Speaking of which, setup.php fails for me when trying to create tables on a fresh db, failing with the error below. In the interim i've been using ZP 1.0.7 to create them. I replaced the backticks in the error message with "+":

    `Creating tables...

    MySQL Query ( CREATE TABLE IF NOT EXISTS ++albums++ ( +id+ int(11) unsigned NOT NULL auto_increment, +parentid+ int(11) unsigned default NULL, +folder+ varchar(255) NOT NULL default '', +title+ varchar(255) NOT NULL default '', +desc+ text, +date+ datetime default NULL, +place+ varchar(255) default NULL, +show+ int(1) unsigned NOT NULL default '1', +thumb+ varchar(255) default NULL, +sort_type+ varchar(20) default NULL, +sort_order+ int(11) unsigned default NULL, PRIMARY KEY (+id+), KEY +folder+ (+folder+) ); ) Failed. Error: Incorrect table name ''`

    Two other things I noticed and weren't sure if they were working as intended or not:

    -If you remove theme.txt from the cache dir, zp loses its current theme and reverts to the default one instead of recreating the theme.txt file.

    -Photos in the albums dir that aren't otherwise in an album of their own don't show up when viewing the main zp page.

    Sorry for long-winded posts :/
  • Rev 360 worked smashingly. At the risk of sounding cliche, you da man Tris.

    :)
  • Hi,
    the subfolder work in view mode with no error, but i'm not able to sort or edit subfolder.

    Continue your good work. I'm a futur user, i only need to be able to use subfolder to change to your album. Very nice, simple et good looking. Exactly what i need!

    Thx a lot
    bumpert
  • @bumpurt-

    if you mean you're needing to sort subalbums, which I'm assuming you are, then that feature is coming in a future release soon. currently there is no interface in the admin for sorting and manipulating subalbums. you can still utilize FTP to rearrange albums and such, but you won't be able to "sort" images until the admin has the facility in place for it.
  • Oh ok :( . Did you have a estimated time when the subalbums will be fully implemented?

    Thx
  • You can keep an eye on the roadmap at: http://www.zenphoto.org/trac/roadmap

    It looks like v1.1 is the target for that functionality.
  • k thx
Sign In or Register to comment.