Small issues after upgrading to 1.4.7

bic

Some small issue I have found after the long time needed upgrade to zp 1.4.7. I don't know which one of them deserve a ticket on gitub

1) Plugin galleryArticles.
I've tried to replace the old Comby-News feature with this new plugin. It appears to work fine (for albums at least), but for albums without description. If the description is empty, no image thumb or link to the album is printed. It only displays a weird `s:0:"";` text.

2) Editing comments with TinyMCE 4.x.
I've disabled this plugin in the front-end for comments at the moment, but it is still enabled in the back-end if it's enabled for zenphoto. For some reason TinyMCE is adding a `

` tag, even using the source code editing. This lead to a different layout for edited comments (unless one disables TinyMCE before editing the comment).

3) Deleting a theme from the admin panel.
When you delete a theme from the themes panel, you don't get any warning message. It may be a bit dangerous, because you are going to irreversibly delete all of the album's files. I don't remember if this behavior was the same in older versions.

That's all so far. If I'll find something else, I'll update

PS
The upgrade procedure went great. I followed a step by step upgrading, from 1.4.4, trough 1.4.4.8 > 1.4.5 > 1.4.6 and finally 1.4.7.

acrylian

1.4.7 or master? 1) Should work correctly with multilingual content now.

2) TinyMCE can be enabled or disabled for comments, gallery items and Zenpage items individually. The latter two on its own plugin options. Somehow I was not aware that it is enabled for the backend editing as well then … Thanks, it should be off on both then.

3) We will take a look

Thanks for the note about the upgrade process. Technically 1.4.4 > 1.4.5 > 1.4.7 should have worked as well as 1.4.7 is a bug fix update to 1.4.6 only (version numbering change).

bic

It's 1.4.7. I'll try the master version of the plugin, thanks.

bic

With master version of the plugin, image thumb is now created in news even for albums without description, but now the title is missing, while the TitleLink is correct.

Edit: actually the TitleLink is different from the standard of other galley news. Instead of the `new-album` prefix there is a `galleryarticles` prefix.

acrylian

Hm, in my tests the title was never missing … Be sure you have the options set correctly with the placeholders (see the option comments how they should be). Also please review your error logs.

Yes, the titlelink is prefixed indeed but that was no change done by me but probably by the orginal author.

bic

Options are ok, may be something is wrong because I uploaded only the plugin files from master into the "old" 1.4.7 installation. It is "description independent" now anyway.

Meanwhile I found another new behavior when navigating through images from search results. In image page, zenphoto tries to use the theme of the album to which the image belongs, changing the layout from one image to the next if they belong to albums with different themes. This is quite weird, I don't know if it's a wanted behavior. May be it deserves a dedicated topic though.

acrylian

General rule of thumb don't upload individual files but only the complete build because of dependencies. Unless we explitly tell otherwise.

Regarding the search. This is actually not really new behaviour. New is rather in 1.4.6 that in dynamic albums images have the url of the dynamic album and not their actual origin (that way you can link to images in dynamic albums from the outside). Please best create tickets for such occurances. Here it gets lost and the chance it is forgotten is big.

bic

Yes, I know that golden rule, but sometimes I try to break it to see if I'm lucky. ;-)

I've opened the ticket about the search issue.

bic

I've installed the complete master build in my local server. The problem is still there: no title.
Moreover, every single image has been imported from combi-news, though I set the options to create news only for albums (this might be because of old combi-news settings).

bic

From the log:
`
NOTICE: Undefined variable: galleryitem_text in C:\wamp\www\zenphoto\zp-core\zp-extensions\galleryArticles.php on line 197

galleryArticles::publishArticle called from require_once (combiNews.php [26])

from galleryArticles->handleOptionSave (galleryArticles.php [115])

from processCustomOptionSave (admin-functions.php [890])

from admin-options.php [443]

{6644:Wed, 18 Mar 2015 12:42:35 GMT}

NOTICE: Undefined index: it_IT in C:\wamp\www\zenphoto\zp-core\zp-extensions\galleryArticles.php on line 197

galleryArticles::publishArticle called from require_once (combiNews.php [26])

from galleryArticles->handleOptionSave (galleryArticles.php [115])

from processCustomOptionSave (admin-functions.php [890])

from admin-options.php [443]
`
Is it something wrong with loading titles options?

acrylian

The plugin has an option to import combinews articles since that functionality is gone in Zenpage. Was that maybe checked accidentally?

I have to take a closer look at this as I was not the author of it and I/we actually don't really use it ourselves.

EDIT: Seems an array needs to be predefined. Still the multilingual mode works best if all enabled languages are set properly (means titles/desc for all languages enabled).

bic

Yes, actually it was checked on purpose, to test it. But the same happens when a new album is created.

Titles are set for all languages (ita-eng) and descriptions too where they are present.
`
NOTICE: Undefined variable: galleryitem_text in /home/web/www.antonioranesi.it/www/zp-core/zp-extensions/galleryArticles.php on line 183

galleryArticles::publishArticle called from galleryArticles::publishArticlesWithCheck (galleryArticles.php [151])

from galleryArticles::published (galleryArticles.php [127])

from call_user_func_array (unknown)

from zp_apply_filter (functions-filter.php [149])

from ThemeObject->setShow (classes.php [511])

from processAlbumEdit (admin-functions.php [2296])

from admin-edit.php [261]

{5734:Wed, 18 Mar 2015 13:32:25 GMT}

NOTICE: Undefined index: it_IT in /home/web/www.antonioranesi.it/www/zp-core/zp-extensions/galleryArticles.php on line 183

galleryArticles::publishArticle called from galleryArticles::publishArticlesWithCheck (galleryArticles.php [151])

from galleryArticles::published (galleryArticles.php [127])

from call_user_func_array (unknown)

from zp_apply_filter (functions-filter.php [149])

from ThemeObject->setShow (classes.php [511])

from processAlbumEdit (admin-functions.php [2296])

from admin-edit.php [261]
`
However this is not a big problem for me, I'm already repopulating manually my gallery news section. It was just to let you know.

acrylian

Ok, good if you get along otherwise. The CombiNews import uses the old CombiNews settings on Zenpage. So if that was set to images it will import the images, regardless of the galleryArticles options.

The undefined variable issue itself should be fixed in the master, the index one might not didn't get to test that. Are the options also set correctly for the languages?

CombiNews will be gone completely - there are still some functions in the code unused - with the next bigger update so I am not sure I really will investigate this.

bic

About CombiNews, are you meaning that you are going to drop the import function only or the galleryArticles plugin also?

Yes, the options are set for both languages. And yes, I can live without this feature anyway.

(I've tested the new file and the title is still missing)

acrylian

We probably drop the import function sometime with the next bigger release. The plugin itself actually is planned to be kept.

The plugin currently simply assumes the titles for both languages are set, if not it is just taken without any check. Will take a look on when I get to it.

bic

Just to confirm that album titles and plugin options for news titles were always present, in both used languages, in every test I made.

acrylian

I can reproduce that. I think I see it now, caused by a recent change

bic

Yes, it works properly now. Thanks!