zp_cookieconsent : how to ?

vincent3569

hi
thanks to acrilian and fretzl for this interesting plugin.
how it supposes to work ?
I have enabled it, but I can see anything : there is no message displayed in front-end

fretzl

Maybe the same glitch I had once.
Go to the plugin's options and just hit "Apply".

acrylian

Hm, didn't have that in the tests. But the browser cache or even the html static cache could possibly interfere. It is otherwise self attaches.

However I did forget to set a default value for the theme used. I added that.

vincent3569

hi

it works better now :-)

for french users of zenphoto, note that "zenphoto core" doesn't need cookie consent.

you need a cookies consent if you use cookies for advertising, social network sharing buttons or audience measurement (except piwik cookie).

some text to read for french users :
http://www.cnil.fr/vos-obligations/sites-web-cookies-et-autres-traceurs/

acrylian

Great. Btw, a French translation for it would be great

vincent3569

hi,

give me the strings to translate and I will translate it.
github iss not installed on my new pc.

acrylian

But why, installing GitHub is very easy, you only need to download their program. Otherwise you need to download the package and use one of the existing translations as the base.

bic

Hi acrylian, a while ago, on GitHub, I've made a pull request with the italian translation for this plugin. I've also opened an issue, because there is some wrong plugin name beside some gettext_pl string. Is this plugin abandoned?

At the moment I've moved quite far from the original code, having added options for dismiss on scroll and dismiss on browse. To do so, I've also modified the original js file from silktide.

Now I'm unsure about the best think to do with my work. Just use it for myself, merge it in your plugin (if you like the new features) or make a new plugin and share it myself?

acrylian

I am very sorry, I was not ignoring your pull request and ticket at all and the plugin is not abandoned. None of my "sideways" plugins is currently actually, even if not updated for some time. Sometimes just nothing needs to be done.

Issues just rush by in the GitHub rss feed and I don't manage to visit the all the repos themselves that regulary to spot them. So it sadly frequently happens that I just miss them like yours. I even suggested a long time ago to GitHub show tickets/pull requests like forks or stars on the main repo overview list once or a separate issue feed…

So some reminder here is a good idea. I really appreciate your contributions and will take a closer look as soon as I can.

having added options for dismiss on scroll and dismiss on browse. To do so, I've also modified the original js file from silktide.

Not debating the sense of this EU cookie notice law at all (it is pretty silly but is is law…) A nice idea but I am not sure dismiss on scroll is legally correct (its offen details in legal stuff). I think it is a requirement that you need to actively agree by clicking on something.

bic

I'm quite sure that dismiss on scroll is legal in many countries. In Italy, for instance, following legal advice from iubenda, it is actually legal. I suppose different countries have different requirements, depending also on the kind of possible third party cookies used. Anyway I've added dismiss on scroll (and on browse) as an option and the default value is set to false.

acrylian

I am not so sure over here though but of course might be legal in some countries.

I could add it but I would generally prefer to not modify third party scripts.It always just complictates updating them. Can't this be done externally somehow instead?

bic

I was trying externally at first and of course it's possible, but with probably too much inline script. A tricky part is to wait for the banner to load before starting onscroll event listener. The original script is also ie8 compliant and by adding the new features inside is also easier to keep the compliance.

acrylian

Have you tried to submit your idea/change to the cookieconsent creator? Just trying to lower update work. I generally follow this policy as it is so easily forgotten/overwritten on updates of third party scripts.

bic

Of course, I see the point. I might try and see what happens. Someone already asked for a "dismiss on scroll" function.

bic

I've added a new pull request with italian update. I also issued a misleading description for theme option.

About the plugin, I suppose I'm personally going to use my custom version of `cookieconsent.js`, beacuse I'm not sure I'll need updates very soon. May be I'll change plugin name and cookie name to avoid conflict, because I'm opened to the possibility of sharing it if someone is interested in it and if it's ok for you.

acrylian

Ok, when already someone asks you should jump in there and maybe even offer your change already. If it goes in I will for sure incorporate it as well. I will maybe try something without modifying as well, it must be possible to check if the banner is already visible or not somehow…

It's all open source so you of course share your own version. Renaming a bit like "zp_cookieconsent_bic-editiion" or whatever is good to avoid confusing.

Thanks for the new translation and ticket.I will it pull in/take a look later today.

bic

Ok, if you want I can share with you a working code for adding externally the dismiss "on browse" function (i.e. clicking on internal links). That also need a cookie to be set, of course, and it means that adding external functions is not totally safe upon future updates.

acrylian

I thought that clicking the link of the overlay sets the cookie? Then it should be set even if we make jquery "fakeclick" it? I didn't really look at what the script itself does, just adapted it.

If you have external code without modifiyin the script itself you could submit it via pull request. Maybe we manage to get the best of both worlds so to speak. Externally it is at least clear where to look for the change/addition itself.

bic

Ok, I tried before faking with `trigger()` and it didn't worked, now I tried again with `[0].click()` and it works. So I'll work again on the external code as soon as I'll have some free time, to submit the pull request.

acrylian

Sounds good and as I thought. Looking forward to the pull request ;-)