Home› Plugins

Commenting Function Bug

Ralf Member
edited July 2018 in Plugins

Hi,
I think I found a small bug in the commenting function:
If you enable the new DSGVO feature "Zustimmung zur Datenverarbeitung" and enable the E-mail notification on new comments no mails will be send.

Without the DSGVO Option enabled emails will be send.

Double checked this with Chrome and Firefox.

Cheers
Ralf

Tags:

Comments

  • acrylian Administrator, Developer

    Thanks, will take a look. Either a mistake or on purpose but I forgot the reason :smile: (Btw it's DSGVO btw or for our English readers GDPR :wink: )

  • Ralf Member

    Thanks :-)

  • acrylian Administrator, Developer

    Please try the support build.

  • Ralf Member

    Hi,
    will try it as soon as i have time - probably the coming weekend.
    I will give feedback.

  • Ralf Member

    Hi,
    just tested it.
    Still no mails send - until I disable the dsgvo feature.

  • Ralf Member

    Hi,
    to make sure that i use the correct updated files:
    Can you tell me which files are modified?

    I have uploaded classes.php from the zp-core folder and the comment_folder and comment_form.php

  • fretzl Administrator, Developer

    You can see here what was changed:
    https://github.com/zenphoto/zenphoto/commit/169c8a159a75b294367496a7ab60d3aad6bee5a9

    FYI: the change works for me.

  • acrylian Administrator, Developer

    I am sure I told before: Never just use certain files to test even if you know which, always use the complete support build (of course not on a live site and not without a backup!). There always might be dependencies somewhere else that otherwise that throw errors. Not in this case but that's the general rule.

  • Ralf Member

    Hi,
    just re-uploaded the files, emptied the browser cache and now it works.

    I think the first attempt fails because of the cache.

    Sorry for the confusion.
    Ralf

  • acrylian Administrator, Developer

    Thanks for the follow up!

Sign In or Register to comment.