1.6a feedback

ctdlg

Hello,

I do use 1.6a on my online site since end of April.
I do enjoy 1.6a a lot !
The best Zenphoto release.

I've got two remarks and one bug issue.

• Remark 1 : admin-edit.php is not fully translated (I know 1.6a is alpha)
  Example : "View Image" button (top left) instead of "Voir Image"

  • Remark 2 :
    Applying changes on page X (X>1) example, X=5
    using /zp-core/admin-edit.php?page=edit&tagsort...
    returns to page one instead of 5
    But changes are ok
    It's not a problem, just a remark !

• Bug : function getAlbumURL in template-functions.php gives the wrong page number in some circumstances.
  1 Using a dynamic album
  2 Page of dynamic album is >1 (example 5)
  3 $album->getLink($page); will add page 5 that might not exist on the album link (album link is correct, page number is wrong)

I know I must not change any file in zp-core folder.
However, editing template-functions.php
I set
$page = 1;
instead of
$page = getAlbumPage($album);

I will use the official template-functions.php file upon 1.6 release.

acrylian

Thanks for your feedback.

Remark 1:
Well, the French translation is on the stat of 1.5.8b according to its internal version.

Remark 2:
I think that is on purpose because you are sorting (in my memory here have not been any changes for ages).

Bug:
$album->getLink($page) itself just creates as link to whatever page number you pass to it. It does not check if that page number actually exists (that would be really overhead as it would need to calcuate that). Checks usually happen before that. We had issue with dynamic albums and pagenumbers before and actually believed we had fixed those…
https://github.com/zenphoto/zenphoto/issues/1317
and probably related
https://github.com/zenphoto/zenphoto/issues/1321

fretzl

I tried to reproduce the "bug" but so far everything works as it should.
Maybe you could elaborate a bit. What theme? Are there only images in the dynamic album or albums , pages, news-articles as well? Etc.
Thanks

acrylian

@fretzl: I don't believe that we have pages, news-articles in dynamic albums at all ;-)

fretzl

Sorry about that. I was thinking about two different things at same time. Men shouldn't do that ;-)

ctdlg

I'm using the basic theme.
Only images in the dynamic album.

Do not use page 1 of your dynamic album to get the bug.
Also check page number of your dynamic album does not exist in your real album.

To elaborate a bit more, I should install a fresh 1.6a, copy my album folder to it !

(because I removed the page number code as written above, and it works as expected.)