Home› Themes

Comments in Effervescence_Simpleviewer ?

ulfben Member
in Themes
I switched to Effervescence_Simpleviewer a week ago or so, and worked some sweet sweet modifications into it. But I've run into some issues and and can't seem to work them out by myself.

First: there's no comment fields in this theme for my visitors to write in. Does this theme even support comments, and if so - how can I add them back?

Second: RSS seems a little buggy. The sitewide RSS work well, the subalbum RSS doesn't work at all at the second tier (ie; albums/2007/) for me. RSS for third tier (albums/2007/September) seems to work, but never updates?

Is this theme a work in progress, or am I just being retarded? Any help would be much appreciated. I'd be happy to "release" my modified version when it's done, if anyone's interrested.

Also, I would be immeasurably grateful if someone could help me add a header-div to the single-image view. More info (and pictures) in this post.

Comments

  • acrylian Administrator, Developer
    Since I made the gallery/album RSS modifications I have not testet it with more than one subalbum level. I didn't even know that zenphoto can have more than one subalbum level until you made this...:-) I try to look into this as soon as I have the time.
  • sbillard Member
    You should get the newest community build. In it there is an updated efferevescence_simpleviewer. Now the comments are controlled by an option which is settable on the Admin options page. (Default is comments enabled.)

    I am afraid I don't understand what you want with the header-div.
  • sbillard Member
    OK, I figured out what you want with the header-div. Get the patches form ticket #128.

    I like the color scheme you have done. Would you post your css (specially after you modify it)?
  • ulfben Member
    Sbillard - I believe I downloaded the theme from trac just last week to work on it. I do have an option in the admin menu for comments (it's on) but they don't show up.

    Just before I started this thread I tried with a vanilla install of Effervescence_Simpleviewer (to make sure it wasn't my modifications that broke it) - however I couldn't see any comments with the clean install either.

    I'll check out those patches though - thanks. And yes - I'll most certainly post the CSS for you. What's the common way to do that around here? Should I post it as a new theme or just start a thread like "blue and basic Effervescence_Simpleviewer mod"? :)
  • sbillard Member
    Last week was a long time ago :)

    You can just post the CSS. I will have to mod it to the stuff I am working on--Soon you will be alble to choose CSS files on the fly!

    Let me know when/wher you post it.
  • ulfben Member
    I pulled the theme from trac and installed it without modifications. I made sure Allow Comments were on, but I still no comment-areas show up.

    Where are they supposed to be? Single-image view? Subdir-view? Perhaps I've just missed them... Is there a demonstration gallery you can point me to, to see how it's supposed to look and work?

    I'll check the header fix out next, thanks.
  • ulfben Member
    Got the header to work just as I wanted. Thank's a lot for helping me out!

    Here's my CSS.
  • ulfben Member
    I noticed the CSS got checked into trac. Please re-download it from my link and add that copy instead. I translated all comments, added information and removed some of the random stuff just 10 minutes after posting it.

    Sorry about that.
  • sbillard Member
    Thanks for the translation. I am working on a few things with the css and effervescence_simpleviewer. I see that comments is broken. Change image.php line #95 from
    `<?php if (getOption('Allow_Comments')) { ?>`
    to
    `<?php if (getOption('Allow_comments')) { ?>`

    By the way, the comments look ok.

    I don't suppose you know where the color for the pagelist disabled links is done? That's all that isn't right (for me) for now.

    Comming with efferevescence_simpleviewer: the ability to select css files from the admin options. Yours will be named 'kish-my father' (CSS file kish-my father.css) I'll put it up on my live album (http://www.albums.sbillard.org) when everything is working.
  • ulfben Member
    Yes!

    Thank you. Comments are working, and I've updated the CSS now (same link) to take care of them properly. Their placement make them look rather out of place, but I haven't figured out yet how I could improve the situation. For now I'll just let the layout be.

    I'm not sure what you mean by pagelist disabled links, but I'm hiding disabled links in these locations:
    `.disabledlink `
    `ul.pagelist li.current a /*denotes the current page were on (1..5 etc) */`
    `.imgnav .imgdisabledlink /*next/prev in single image view*/`
    `.albnav .albdisabledlink /*prev/next links i subalbums (upper part of the screen)*/`

    And then there's one more which I haven't touched:
    `ul.pagelist li a, ul.pagelist span.disabledlink `

    Dunno if this is any help to you though.
  • sbillard Member
    Got it. New version is up on the SVN with a couple of added schemes. These show the disabled links, so you may want to change them.
  • ulfben Member
    It seems you forgot to replace/edit kish-my father.css with my comment-capable copy. :)

    A lot's of "unknowns" have been replaced and comments look proper now.
  • sbillard Member
    Guess I got an earlier version. Thanks.
  • ulfben Member
    I know what I would like to do with the comments now. I'd like to have a column next to the image, which holds all comments and - at the very bottom of it - the input form.

    Visitors wont have to scroll to see if there's any comments for a picture.

    If anyone has already invented this particular wheel, please let me know how to wield that dark div magic. :)
Sign In or Register to comment.