Home› General support

Where do I submit a zenphoto mod to?

Donkikong Member
in General support
Hi,
I've added a feature to create custom thumbnails of images.
You can optionally predefine aspect ratio, minimum sizes etc or zoom in to a particular point of interest on an image.

Where should I submit the code to?

Thanks,

-- Donkikong

Comments

  • acrylian Administrator, Developer
    Interessting feature, I have thought about this, too. The easiest would be to post a download link right here.
  • aitf311 Member
    What you should do is create a trac ticket if it is something that should be included in the zenphoto release. I would argue that your mod is. If it is not something that should be included, you should post it on the zenphoto hack page on the wiki: http://www.zenphoto.org/trac/wiki/ZenphotoHacks

    Submit new ticket here: http://www.zenphoto.org/trac/newticket
  • Donkikong Member
    Thanks,
    I need to find a moment to go through the code and make sure it confirms to zenphoto coding format and standards.
    It was something I did for a client, but thought that I should share it with the community as ZP has been extremely useful to me in writing various photojournalists and photographers websites.

    I'll put it in the track once it confirms to ZP standards.
    Thanks again
    -- Donkikong
  • Megan Member
    I'm trying to do the same - I submitted a ticket and it's assigned to me. How do I actually submit my changes? Do I attach a file to the ticket?

    Thanks for any help - I'd like to get this uploaded before I forget what I did...
  • aitf311 Member
    Yea, you can upload the patch or file to the ticket.
  • sbillard Member
    You should attach the patch to the ticket and let us know it is there.
  • Megan Member
    Do you want a patch file or can I just upload the files I changed? This is my first contribution to an open source project (yay!) and I don't have any experience with patch files. It seems a bit complicated but I haven't found a good tutorial yet. I guess I'll just have to try it :)
  • sbillard Member
    It is best to upload a patch file. If you upload the changed file and someone else happens to be working on that file at the same time there is a good chance of loosing changes.

    If you are running Windows, I suggest you look at a program named Beyond Compare http://www.scootersoftware.com/. It is a great help in seeing what the differences between two files (or folders) are. It will also generate a patch file. Use it's Unified Diff option.
  • Megan Member
    I'm on OSX and Ubuntu but i've found something that looks like it will do it. Thanks!

    Edit: Another noob question - which build should I do the compare with? The 1.1 version or the latest nightly?
  • sbillard Member
    You should do the compare with the build that you modified in the first place. What we want is just the differences that your change made.
  • Megan Member
    Oh good! I was having trouble because the latest build is different from the one I worked with.

    If I upload them and close the ticket is that enough for you to know the patch is there?
  • sbillard Member
    You should upload your changes, but leave the ticket open. It will get changed when the changes are incorporated in a build. Post a message when you have done the upload.
Sign In or Register to comment.