Patch: Fix stopdesign edit description alignment problem

xkahn

When editing the description of an image, the alignment appears off. (Centered suddenly on the screen instead of where the description was originally.) This patch fixes the problem. The patch is small:

diff -r -u -b zenphoto/themes/stopdesign/css/photos.css zenphoto-2/themes/stopdesign/css/photos.css
--- zenphoto/themes/stopdesign/css/photos.css 2008-02-14 09:36:29.000000000 -0800
+++ zenphoto-2/themes/stopdesign/css/photos.css 2008-03-07 17:35:56.000000000 -0800

padding:0 15px 0 0;

}

#desc #imageDesc {

- padding-left:265px;

+ margin-left:265px;

+ }

+#desc div[style="display: block;"] {

+ margin-left:255px;

}

#desc p.posted {

margin-top:1.25em;

I haven't tested it extensively -- it works for me and my family. This fix makes me able to edit the description of videos as well.

xkahn

Ugh. I forgot the link to the patch:
http://xkahn.zoned.net/software/zenphoto/patches/zenphoto-1.1.5-stopdesign-editdescription.patch

acrylian

Thanks for your patches. Could you please use our ticket system on the trac for this in the future.

xkahn

Yes... I guess I should have realized that patches should go in trac. Sorry.

acrylian

Never mind...:-) Thanks for creating the tickets.

OddJob

I have the reported issue and the patch is applied on the download that I installed from. I have prodded and poked the settings, because the css looks basically right to me.

Has anyone got any suggestions or pointers for me so that I can pin down what is causing the misalignment of placed descriptions.

Thanx in advance.

sbillard

Not sure exactly what you have done. But these original posts are many months old. You have not mentioned (as requested in http://www.zenphoto.org/support/topic.php?id=3760) any information about your installation.

The current version of zenphoto is v1.2.2 and there are no patches against it for stopdesign so I can only assume you are running on an older version. Move up to the current one.

code

hmm

acrylian

"hmm" is now a very descriptive post...:-)

OddJob

I am sorry guys. I try to be cautious with regard to the protocols of working with Open Source material. I have seem the earlier guidance notes post. You seem to be right about me leaping in without having gotten properly prepared.

I had installed a 1.04 version of the theme. I have looked "out there" again and have a 1.06 beta. I understand a little more of the history of the development of this theme, too.

I will install this different version and see what happens.

If I have more trouble, I will be better informed, too.

Thanks. Apologies, because I have done so much work in Open Source that I really should have known better.

OddJob

Touch wood; this has worked out very nicely.

Thanks for your help, because your feedback gave me the right sort of encouragement to search out what turned out to be the right answer. BTW, I had the latest version of ZenPhoto installed. The theme repositories may be are a bit higgledy piggledy, though.

The functioning site is http://bridgecamerausers.co.uk/zp/

acrylian

Good to hear that you managed it. Well, the thteme repository actually marks the included standard themes like stopdesign is one. That means the actually newest version of those currently four developer maintained themes is always included in Zenphoto (the zenpage-default theme also is developer maintained but only available in the Zenpage plugin package).

OddJob

I have now had a a much better chance to explore the range of themes and the ZenPhoto info pages, too.

There is indeed a bit of genuine tinkering with the non-supported themes that is required. I do not know quite what I did and where I downloaded from, earlier. The on-board complement of themes does seem to be smaller than that documented, but what the heck! I also got a bit confused between stopdesign and stoppeddesign.

There is always a bit of a learning curve in getting acquainted with new open source software. But yes this is well organised!

I had earlier installed zenpage, but I can get the documentation hacks that I need by hard coding the index.php for the theme.

acrylian

Ok, we are always open about feedback. Yes, indeed the stopdesign and stoppeddesign theme names are confusing but the original author - these are adapted Wordpress themes I believe - named them that way..:-)

OddJob

The variants on that theme evidently still keep on coming! Quality ++ stuff!

sbillard

There is only one stopdesing theme provided in the zenphoto distribution. It was originally crafted by Douglas Bowman, but he appears to have moved on from it. There were two user created versions done in the earlier days of zenphoto. The one named `stoppeddesign` and one with the same name as the current distributed `stopdesign`. Both these themes fell short of matching the style and functionality of Bowman's original (his was not a zenphoto based theme.)

Mark Galeassi and I did a new original port of the design to zenphoto. This is what is distributed with the package. Also, this is the only version with developer support. If you wish support for the other version you will need to rely on its original zenphoto authors.

OddJob

Yes Think Dreams variant I have downloaded. It breaks, and I have earlier found that the messaging system wrt deprecated PHP functions gives really good clues. So I may be able to tinker with it successfully.

I will do such work in Linux, though -- because it crashes Firefox in M$ Windows!