Clear cache bug

williamz

I just posted up a clear cache bug in the bugtracker that I have noticed wasn't working. This happens when you hit the check box in certain pages and the page does a POST method instead of GET. So it may say it's clearing but it really doesn't.

Here's the bug fix if anyone wants to temporarily fix it.

Line 57 cache-images.php
old: if (isset($_GET['clear'])) {
new: if (isset($_GET['clear']) || isset($_POST['clear'])) {

acrylian

But you know that this "clear" checkbox on the edit page is related to the "pre-cache Images" button? So if you click "pre cache images" and have the checkbox enabled this clears the cache of that album first and then generates new cached images of all images in that album. If you don't check the checkbox, it precaches only previously uncached images of that album.

So the cache of course is never empty afterwards. Simply checking it and hitting save for example won't do nothing.

Just to be sure I understand you right, because it is working as supposed in the latest nightly build. Maybe the checkbox is not placed to make that relation clear.

williamz

yes you are correct. the bug is when you check the box, you think it's clearing but it doesn't. that's because it's doing a POST data and the routine doesn't look for that. You will see it say Clearing and Pre Caching.... but it doesn't 'clear'

acrylian

Ah, seems I was mistaken, you are right, that indeed does not get cleared...

I will add you fix.