Home› General support

RFC - Requirements when posting comments

oscar Member
in General support
In functions-controller.php function zp_handle_comment(), it checks for:

`[isset($_POST['name']) && isset($_POST['email']) && isset($_POST['comment']))`

However, right after that, it checks if these exists again, and if not, assigns "". What is the reasoning behind this? This means that even if I don't require e-mail, I can't remove it from the theme.

Should be safe to remove the first check altogether, no?

Comments

  • sbillard Member
    The checks seem out of place. You should be able to remove them. The required fields tests should be enough.
  • oscar Member
    Great, thanks. Will you get this into trunk as well? I'm sure I will forget why comments aren't working for 1.3 otherwise :)
  • sbillard Member
    Done
Sign In or Register to comment.