Comments disabled in latest version

pehansen

Hello,

I have tried to install latest version of Zenphoto with zenpage.... I have a problem with comments, suddenly after working fine, one or more albums are closed for comments, even though all settings are set to enable comments...

Even tried to install from scratch... create new album... everything OK... comments working... then next day upload some new images... and now gallery closed for comments.... even though all settings show the opposite...

nynexshadow

Hi, I seem to have the same issue with zenphoto-2009-03-08-trunk. I have looked into it and if I check the box on the admin section of the album for allow comments then save it for some reason it doesn't save it. I have edited the commentson field of the sql database which has now allowed comments again.
Obviously i realise it's not fixing the problem but it's a temp workaround.

sbillard

Thanks, Seems an error has crept into the allow comments form. It will be fixed in tonight's build.

slaattnes

The same error have occured in the two latest builds (4500 and 4505).

slaattnes

And 4516.

acrylian

You really have the comment form plugin activated?

slaattnes

Yes and the check box for aticles are on.

acrylian

You can also set comments on/off for each article/page specifially. Other than that I have no idea as everything works as expected here.

slaattnes

Maybe it have something to do with the renamed pages and news because my site is multilingual, but albums should not be afected.

I deleted the whole previous site and put the new build there. The problem is that the "General" tab on album edit (admin-edit.php) isn't showing so there is no way to set comments on or off (btw. souldn't the comments be on by default?)

acrylian

Yes, comments are actually enabled by default. If something is not showing up (I guess you mean the "general" in the right sidebar) something is not installed correctly.

The acutal name of a page/article (the titlelink) is not dependend on mutlilingual titles.

slaattnes

Yes I meant the general on the right sidebar. I runned setup.php again. What else are there to install? Maybe there is a mysql issue?

acrylian

I have no idea, never encountered this issue. Any errors in the server log?

slaattnes

No errors in the logs. Which table in the database are responseble for handeling the on/off comments information? This are my tables: zp_options, zp_albums, zp_images, zp_comments, zp_administrators, zp_admintoalbum, zp_tags, zp_obj_to_tag, zp_captcha, zp_zenpage_pages, zp_zenpage_news2cat, zp_zenpage_news_categories, zp_zenpage_news

Edit:

For now I just set commentson to 1 on the albums in zp_albums

slaattnes

I see now that admin-edit.php is behaving very strangely. When I rename an album and saves, it retuns a blank title and turns comments off...

slaattnes

I have another sugestion; maybe there are conflicting plugins in the newer builds? I'll try to disable them to see if the problem stops.

slaattnes

Last post:

I just uploaded the last build (4518) to a different server and with a different database but I have the same problem. Can it then be a browser problem?

I've now tried Internet Explorer 8, Opera 10 and Firefox 3.5 so maybe not.

URL to testing server: http://folk.ntnu.no/danielto/zenphoto/ and the username and password is admin

Do you see the "general" right sidebar acrylian?

acrylian

I did log in for testing and I also did not see the general sidebar. But something must not be right with your installation or the package you downloaded because I see this error in the source code:
`Fatal error: Call to undefined function updateThumbPreview() in /web/folk/danielto/zenphoto/zp-core/admin-functions.php`
I have never encountered that.

sbillard

Hi.

I logged into your test site, enabled the comment_form plugin (which you had said was enabled, but it was not!) Now I can see a comment form on the site.

slaattnes

sbillard: On the test site I didn't enable or disable any plugins to easier find the problem (I didn't say it way enabled - on the original site on the other hand it is enabled.) Anyway the problem is that the general sidebar isn't showing, but thank you:-)

acrylian: I can try another build. Which build do you have which are showing the general sidebar? Also, isn't the installation just to run setup.php? I can't see what I could do wrong when installing.

Thanks for all the help.

slaattnes

There is no `updateThumbPreview()` in admin-functions.php. Hm...

sbillard

`updateThumbPreview()` is a Javascript function. It is defined in admin.js. No way that PHP should be trying to execute it. Maybe your files have got corrupt.

slaattnes

Yes. I can try to upload the build a second time? Weird that both the last and this build would be corrupt though.

slaattnes

I now deleted the test build and uploaded 4516. This time too the general sidebar on albums are missing: http://folk.ntnu.no/danielto/zenphoto/zp-core/admin-edit.php?page=edit&album=test

It can't be corrupt every time on different servers and different builds. This is truly a weird problem. Do you get the same error as last time acrylian?

Edit: `Fatal error: Call to undefined function updateThumbPreview() in /web/folk/danielto/zenphoto/zp-core/admin-functions.php on line 1209`

I can't find updateThumbPreview() in /zp-core/js/admin.js

acrylian

That function is defined in admin.js around line 191 but only in the nightly build, not the 1.2.6 release. If it is not there you probably have mixed up files with the 1.2.6 release somehow.

slaattnes

No. I found it now:

`
function updateThumbPreview(selectObj) {
if (selectObj) {
var thumb = selectObj.options[selectObj.selectedIndex].style.backgroundImage;
selectObj.style.backgroundImage = thumb;
}
}
`
This is from admin.js on the server and the fatal error from admin-functions.php on line 1209:

`<?php updateThumbPreview(document.getElementById('thumbselect')); ?>`

acrylian

Maybe a file permission issue so that it is not loaded?

slaattnes

Hm I just set everything to 777 but there where no difference.

acrylian

I guess we are running ouf of ideas rapidly... You need another server..;-)

slaattnes

I uploaded 1.2.6[4335] to the same server and in that version the general sidebar works so isn't it something wrong with the never builds then?

acrylian

It is really getting weird now. I see it indeed on one of my three local svn installs (the bottom buttons are also missing). It even remains in that one after I got the files fresh from svn..

Strange things are happening here, as now in the one that shows all sidebars TinyMCE is not loaded anymore without any noticably reason or error... Will talk with sbillard...

acrylian

After some odyssey I think I fixed it. Please try the svn or tonight's nightly so we are sure... Strange one this was...