Home› General support

trouble with comment per page in admin

vincent3569 Member, Translator
in General support
hi

since I migrated to 1.4.5.2, I have only one comment per page on admin page.

I don't found a way to change this value in admin.
Can I setup this value (to 20 comments per page for example) ?
Is it an issue of this release ?

Comments

  • acrylian Administrator, Developer
    Options > Plugin > comment_form > Comments per page
  • vincent3569 Member, Translator
    yes, I finally found it

    but, I found something strange in the code

    some php files use COMMENTS_PER_PAGE (admin-comments.php) and other files (comment_form plugin files) use comment_form_comments_per_page.
  • vincent3569 Member, Translator
    something else strange (no matter with other trouble):

    my database contains a lot of `zp_plugin_)*` options, and I have `zp_plugin_)` to.

    there are some deprecated options (due to an type issue in a older release ?)

    Généré par: phpMyAdmin 3.5.5 / MySQL 5.1.66-cll
    Requête SQL: SELECT * FROM `zp_options` WHERE `name` LIKE '%plugin_)%' ORDER BY `zp_options`.`id` ASC LIMIT 0, 30 ;

    Lignes: 30
    id ownerid name value theme creator
    1728 0 zp_plugin_)colorbox_js 1 NULL
    1729 0 zp_plugin_)akismet 1 NULL
    1730 0 zp_plugin_)auto_backup 1 NULL
    1731 0 zp_plugin_)comment_form 1 NULL
    1733 0 zp_plugin_)hitcounter 1 NULL
    1735 0 zp_plugin_)contact_form 1 NULL
    1745 0 zp_plugin_)dynamic-locale 1 NULL
    1746 0 zp_plugin_)ipBlocker 1 NULL
    1747 0 zp_plugin_)flag_thumbnail 1 NULL
    1750 0 zp_plugin_)exampleMacros 1 NULL
    1751 0 zp_plugin_)zenpage 1 NULL
    1753 0 zp_plugin_)security-logger 1 NULL
    1754 0 zp_plugin_)site_upgrade 1 NULL
    1761 0 zp_plugin_)slideshow 1 NULL
    1762 0 zp_plugin_)jplayer 1 NULL
    1777 0 zp_plugin_)rss 1 NULL
    1778 0 zp_plugin_)seo_zenphoto 1 NULL
    1779 0 zp_plugin_)html_meta_tags 1 NULL
    1781 0 zp_plugin_)uploader_jQuery 1 NULL
    1782 0 zp_plugin_)googleVerify 1 NULL
    1783 0 zp_plugin_)seo_cleanup 1 NULL
    1784 0 zp_plugin_)search_statistics 1 NULL
    1785 0 zp_plugin_)tiny_mce 1 NULL
    1786 0 zp_plugin_)image_album_statistics 1 NULL
    1787 0 zp_plugin_)GoogleMap 1 NULL
    1788 0 zp_plugin_)zenphoto_sendmail 1 NULL
    1789 0 zp_plugin_)uploader_http 1 NULL
    1792 0 zp_plugin_)user_login-out 1 NULL
    1793 0 zp_plugin_)federated_logon 1 NULL
    1823 0 zp_plugin_)zenphoto_news 1 NULL
  • acrylian Administrator, Developer
    1. One is a constant and one the option probably. We can't say much without concret line numbers. (in 1.4.6 there will be two options, on for back and one front end one).

    2. Could be a typo or a update issue. So basic infos like what you upgraded from would be helpful…
  • vincent3569 Member, Translator
    - for comments_per_page
    there are 2 options in database :
    id ownerid name value theme creator
    495 0 comment_form_comments_per_page 20 zp-core/zp-extensions/comment_form.php
    1724 0 comments_per_page 15 zp-core/setup/setup-option-defaults.php

    only comment_form_comments_per_page seems to be used, but you don't have a purge of the older option.

    https://github.com/zenphoto/zenphoto/commit/30505f8efce3b803ce83ff73014b56d594cca387

    - for `zp_plugin_)*` values, I regulary upgrade my zenphoto installation and I have done an upgrade from 1.4.4.6 to 1.4.5.1, and 1.4.5.1 to 1.4.5.2.
  • acrylian Administrator, Developer
    Then it is an older option. There is generally no purging of old option entries since we never know if it is from an disabled plugin or theme someone might want to use later again (unless that changed and I am not aware of).

    Regarding the `zp_plugin_)` ones I do have those in my test install as well but I have no idea where these come from. It might have been an already corrected typo from the beta. Maybe sbillard remember something like that.
  • sbillard Member
    The `zp_plugin_)` options are clearly form a bug at some point in initializing options. I did find some in my database, but after removing them I have not been able to generate any new ones.

    The `theme` and `creator` fields can be of some use in purging obsolete options. Also generally we try to purge options if we migrate them. At least more recently, we try to name options with the creator to prevent accidental duplication.

    Other that these hints we have no way of knowing if an option is still valid.

    I do not have the `comments_per_page` option in my database, so I suspect that its purging somehow got skipped on your site. Perhaps due to beta software--the option may not have been initially named correctly.
  • vincent3569 Member, Translator
    @sbillard :
    about `comments_per_page`, see the commit : https://github.com/zenphoto/zenphoto/commit/30505f8efce3b803ce83ff73014b56d594cca387
    the option has been renamed, but old one has not been removed
  • sbillard Member
    Seems the option was introduced with the incorrect name in the 1.4.5.1 release and then corrected.
Sign In or Register to comment.