404 not multilingual

I think I found an error. The 404 page does not get translated like the other theme files.

Comments

  • What Zenphoto version are you using? The 404 page is translated for me on the nightly build.
  • I'm using 4528 so I guess it's something I've done. Any suggestions?
  • Out of curiosity I went to your website and tested the 404 page. It is translated for me:

    `
    Uff da!

    Adressen du ba om, eksisterer ikke eller har restriksjoner.

    Album: test404
    Theme page:
    `
    I'm not quite sure why you would be having problems.
  • That text I've written in the 404.php but the search and sidebar is still english (which should get it's text from the language file like the rest of my theme.) It's gettext code is the same as in the other files so I don't see why its not translated: `gettext("Search gallery")` and so on. There shouldn't be a calling for the gettext/translation file in the document should there?

    I also see that 404.php is the only page that doesn't take

    `
    <?php
    if($_zp_gallery_page != 'contact.php') {
    printCustomPageURL(gettext('Contact us'), 'contact', '', '');
    } else {
    echo gettext("Contact us");
    }
    ?>
    `
    from sidebar.php. Maybe that can give a clue to the problem.
  • acrylian Administrator, Developer
    It's a bug .... Look at the first line there is a call to `setThemeDomain("zenpage-default");` This needs to be remove as this forces the page to use a separate theme translation (which has other problems as then the main translation would be ignored). This is a leftover from times when the Zenpage plugin and the theme where released independently.
  • I see it. Hah! I'm blind... The first sentence in the whole text are the problem. Thank you very much:-) What about the missing Contact form URL on the sidebar? I guess the page should be "approved" for sidebar-contact page URL somewhere but I don't have any suggestions. It's not in the contact_form script.
  • acrylian Administrator, Developer
    The gettext issue is fixed in the nightly btw.

    No idea currently, actually the official zenpage-default 404 page has no sidebar at all, because the 404 page is a little out of context actually (there were some issue with the other functions because of that if I remember correctly).

    Thte contact us page is a separate (basically static) theme page named contact.php.
Sign In or Register to comment.