Cyrillic transliteration in album names

divan

There is some issue with Cyrillic names when creating new albums in Zenphoto 1.2.7 - the error "Album_name already exists" returned and album is not created. There are actually two issues - the interface and the characters transliteration for the album name.

I'll start from the second, the transliteration - I've found that plugin zenphoto-seo converts only accented characters and leaves a lot of others commonly used Unicode characters, including Cyrillic ones. I've made a new filter, based on zenphoto_seo, which transliterate such characters;
http://divan0.org.ua/web/zenphoto/filter-zenphoto_ascii.php.gz
There is also a possibilty to add these characters to the existing zenphoto_seo plugin, here is the patch:
http://divan0.org.ua/web/zenphoto/plugin-zenphoto_seo.diff.gz
The both ways works for me.

And first issue, the interface - in 1.2.6 there was an option to manually enter album's title and path before submitting. Now we have javascript-prompt with only one field - title, which is supposed to be tranliterated properly. But it doesn't. So, one of the solutions I see is to make changes in the interface to leave the possibility of entering path manually. Or, even better, prompt to enter path manually in case of error in transliteration).

acrylian

Also 2nd first: That sounds a good idea to incorporate this. We knew that this could be improved as surely missed some chars.

1st: Not sure what you mean. If you select "Make a new album " you can still enter the folder name manually by unchecking the "Auto generate" next to "with the folder name:" field on the upload page.

acrylian

Btw, if you do welcome improvements likes this you can also open tickets.

divan

@acrylian,
| you can still enter the folder name manually
oh, right, I missed it and used "Create subalbum" button in Albums page.

acrylian

Just a detail but the subalbum creation speaks of the "album name" what in Zenphoto terms of course means the folder name and not the title. You can edit the title later to your liking then.

divan

| Just a detail but the subalbum creation speaks of the "album name" what in Zenphoto terms of course means the folder name and not the title
I understood it opposite - user enters "Title", it's changed to seoFriendly name and assigned to the "folder name". But anyway, it will solve the problem, but looks like a trick, which, besides, adds additional work.

@acryllian, I didn't open the ticket, because I want to hear developers' opinion - should I leave it as a new plugin(zenphoto_ascii) or propose the patch for the zenphoto_seo plugin(and open the ticket in this case)?

acrylian

We can of course make it more clear with an extended comment I guess. I don't know why this does not clear the name seo friendly, probably because the JS stuff or we simply forgot it or..... Don't know right now. We would have to look.

I had not really time to look at your plugin but it seems to make sense to clear out any special char that should be avoided, regardless if many people will not use Cyrillic chars.

So feel free to submit the patch.

sbillard

Also consider that the reason we made this function a plugin is so that custom versions could be made as needed. So mayabe your version is best left as an alternative. In which case, we can add it to our plugin repository.

divan

Ok, I've added a ticket.
For me, the accented characters are the same subset as other non-ascii chars, used in many european languages. Maybe I'm wrong, but from this point of view there is no sense to divide the 'accented' and 'other non-ascii' chars into the two separate plugins.