Zenphoto 1.4.5 - html markup validation issue?

Ra10

Hi,

first of all thanks for the great work to all zenphoto contributors.

I am currently theming a gallery page with 1.4.5 dev-build.

In my templates I use printCustomSizedImageThumbMaxSpace a lot, which works fine except W3C validation.

The image URL looks like:
'/zp-core/i.php?a=cd/kbs225&i=IMG_5516.jpg&q=95&t=1&wmk=%21&check=99f4dbe314464fa69ccf16611320c4b36dc34ced'

As you know the & should be replaced by '& amp;'

Therefore I tried something like:
'echo (htmlspecialcars(printCustomSizedImageMaxSpace(..)));'
But that did not solve the problem.

Question: Is this a bug remaining in 1.4.5 or a "feature"? If it is a feature, what would be the correct output statement to use for getting valid html in a theme file?

Thank you very much in advance
Ralf

acrylian

I just looked, the internally used printCustomSizedImage() function uses pathurlencode() actually... Probably an oversite. Best you open a ticket on the issue tracker.

Generally that image processor link should appear only once until the image is cached. Then the proper link to the cache should appeard (which has no ampersamds).

Ra10

Hi,
I have investigated the issue further. You are right, once the pre cache is configured and called properly (cache sizes and specifying width AND height for max size option) the links to the cached images are displayed correctly.

However, one small ampersand-issue remains when applying printSearchForm(), which outputs the following line:
<input type="hidden" name="redirect" value="/index.php?userlog=1&album=bahnreisen%252Fxinjiang" />

sbillard

That is not coming from `printSearchForm()`.

Ra10

Sorry, the wrong HTML line is generated by printLoginForm...
which I call for login from frontpage. Besides the validation problem there is an error after login from album and image pages (requested page could not be found).