GoogleMap plugin

vincent3569

hello,

with the new googlemap plugin, is it possible to have an automatic zoom level to have all the geolocalized photos in the google map ?

I have tried with 'auto' in the admin tabs, but it doesn't work.

thanks for help

sbillard

If you have multiple points on the map it will automatically zoom to show them. (This would happen, for instance for an album map.) If you have only one point, as for an image, there is no auto-zoom. (What criteria would it use to zoom to?)

vincent3569

I use Google Map plugin in album.php.
I have several localized pictures, but there is no automatic zoom to show all of them.

is there a specific value to set in "Initial Zoom" ?

sbillard

The only zoom value is the one in the options. Can you post a link to the album where the map does not show all points? It has not failed to do so yet in my testing.

vincent3569

hello,

there is a link to my pre-prod web site with ZenPhoto 1.4 :
http://vincent.bourganel.free.fr/zenphotoNB/index.php?album=neige-a-la-jasserie

There is no value in "Initial Zoom" in plugin tabs

sbillard

The initial value should have defaulted to 16, but of course, if it is ever set differently the default will not be re-applied.

Looks like I need a password to view this page. Maybe you could have a public example. Also try setting the initial zoom to 16. Maybe there is a problem if it is empty.

[edit] I set it to empty on my install--no change in behavior, still zoomed to include all the points.

vincent3569

There is no pwd on this album : http://vincent.bourganel.free.fr/zenphotoNB/index.php?album=neige-a-la-jasserie

I've tried to set zoom value to 16, but the problem remains the same : no zoom on all the points

sbillard

I can't really say what is wrong. There is a bounds computed. I can't tell if it is correct, though. Can you try using the option that initially hides the map. See if that makes a difference. (This makes no difference for me.)

Otherwise, I guess the next step is to make a ticket and attach some images to it so I can experiment. Who knows, maybe being on the other side of the world matters. One other guess is that maybe this version of the Google API actually is localized. If so, then the gps coordinates would need to have commas instead of periods.

There is a function in googleMaps named `addPoint()` that currently swaps the comma for a period. You might try disabling that.

vincent3569

hello

despite initially hiding of the map, the problem is the same.
I will create a ticket.

what sort of images you need ? some of my georeferenced pictures ?

sbillard

How about those on the album you linked above.

vincent3569

I have done some attempts with google_map with ZP 1.3.2.1 and the same georeferenced images :
http://vincent.bourganel.free.fr/zenphotoNB3/index.php?album=neige
it's ok with version of the plugin.

I have created a ticket with some attached pictures.

sbillard

That plugin uses a different version both of the support software and the GoogleMaps API. Comparisons are irrelevant.

vincent3569

of course, but it eliminates problems on photo EXIF data.

sbillard

Well, as the response on the ticket says, I am not seeing the issues on your site or with your images.

But feel free to use that plugin so long as it works for you. However, note that it will no longer be supported.

vincent3569

you don't want support the GoogleMap plugin for Zenphoto's next release ?

it's really bad news: I wanted to use this feature on my site and the plugin is definitely helpful for other users of Zenphoto.

is there no developer's forum for the GoogleMap Api who can help you to solve the problem ?

other solution : restore the GOOGLE_MAPS plugin that existed on the zenphoto version 1.3.2.1.
it used the API V1 which is a bit old, but this plugin worked well

what is your opinion about that ?

acrylian

You have not read correctly. The `GoogleMaps` plugin is supported and will be but but the older `google_maps` plugin you use is not anymore.

vincent3569

Oups, sorry for the mistake :-s
I understand that google_maps will not be supported anymore.

Nevertheless, until the problem on the GoogleMap plugin (included in ZP version 1.4) will be solved, can you explain how to use the plugin GOOGLE_MAPS (included in version 1.3.1.2 ZP) ZP on 1.4?

acrylian

I am not familiar with both plugins (I have no use for geolocation stuff myself) I guess you can use it as ever, enable it and change the calls to the new maps plugin to use the old ones on your theme.

sbillard

Well, Google will not support that API, so there really is not any futue in it.

As to "correcting" whatever seems wrong with your site. That certainly will not happen here on the forum. Unless you are willing to make the ticket system work, nothing will happen.

As I have said (again and again) This problem does not occur when I test your images nor when I visit your site link as posted above.

So unless someone else experiences this problem and is willing to work for a solution, nothing will get changed.

vincent3569

hi,
some news on that issue :
when I force english language, googlemap well displays my pictures (with correct zoom level)
when I choose another language (or if I choose "HTTP Accept Language "), the zoom level is incorrect...

do you have you some news on the fix of this issue ?

sbillard

Is this with the 1.4.0.2 release? If so you will most likely have some conflicting CSS. Be sure that the "container" where you wish to display your map is at least as big as the area needed to display the map. Otherwise it will not render correctly (know google map issue having nothing to do with zenphoto.)

BTW, did you not get updates from the ticket?

vincent3569

In fact, I have migrated to 1.4.0.2.
Now googleMap plugin is going well and well displays my pictures (with correct zoom level)!

But I found a little bug :
I wrote this line `<?php printGoogleMap('', NULL, false); ?>` to automatic display the map, without any text : but it doesn't work.

I read /zp-core/zp-extensions/GoogleMap.php :
lines 286 to 288 : there are a few lines of code that are unnecessary :
` if (empty($text)) {

$hide = 'hide';

}

`
Are you OK with that ?

sbillard

That should have read `$hide='show';` If there is no text, there is nothing to click on to reveal the map.

vincent3569

I don't want any text to reveal the map.
I want to always have the map displayed, if they are some localized pictures

accordind to me, the lines 286 to 288 are unnecessary : there is other code for hidding or not the map

vincent3569

hi

I have installed the nightbuild (1.4.0.2 [6701]).
the problem is still the same :
with english language (and no european languages), pictures are displayed with a correct zoom level in googlemap.
with european languages (french, spanish, german, italian,...), the zoom level is incorrect.
sbillard, acrylian, I have activated dynamic-locale plugin : you could see the problem here : http://vincent.bourganel.free.fr/zenphoto_test2/index.php?album=neige

sbillard

Sorry, your site behaves very badly. If I select another language, it takes me to the home page. But it does not remember the language, so I cannot get to the page with the map and be in anything but English.

acrylian

Indeed, I am directed to the home page as well when selecting a language. The language is actually selected correctly.

But besides that I am able to see the issue with the automatic German language setting. I sent screenshots via mail to you, sbillard.

sbillard

Is there some reason that you do not want to use the ticket system to persue this? Because if you don't do that the problem will NOT be solved.

vincent3569

hi

I have reopened the ticket #1797, and added some screnshot.

vincent3569

hi

I have tried the NightBuild [6763].
Now the googlemap plugin works fine : the map is displayed with correct zoom level, with all languages.

But I found another mistake :
on changeset [6684] http://www.zenphoto.org/trac/changeset/6684, you have added this code :
`

if (empty($text)) {

$hide = 'show';

}

`

it was OK for my pesonnal use (I want to always have the map displayed, with no text to reveal the map, if they are some localized pictures)

but now, you have this code :
`

301 if (empty($text)) {

302 $hide = 'show';

303 }

304 if (is_null($hide)) {

305 $hide = getOption('gmap_hide');

306 }

307 if ($hide) {

308 $hide = 'hide';

309 } else {

310 $hide = 'show';

311 }

312

313 if (!is_null($callback)) {

314 call_user_func($callback,$MAP_OBJECT);

315 }

316 if (empty($text)) {

317 $hide = 'hide';

318 }

`

it seems that lines 316-318 are redundant with lines 301-303 but the last ones are doing the wrong thing.

sbillard

You are correct. This is one of the areas that is quite different in the Development build. The translation to the Support build was not correct. We will get it stratghtened out in tonight's build.