printPasswordForm() and zenphoto_authority (1.4.1-beta)

micheall

I am getting a LOT of these errors in my log:

[warn] mod_fcgid: stderr: PHP Notice: printPasswordForm (called from user_login-out.php line 116) is deprecated printPasswordForm custom theme password forms is deprecated. You should style the form created by the Zenphoto_Authority class (or its derivatives) instead. Use of these forms will prevent alternative credentials implementations from working with a theme. in /home/inthemdl/public_html/zp-core/zp-extensions/deprecated-functions.php on line 70

Now mind you, I don't have any special login form or anything. The only thing I'm using is the user loginout plugin to display a login form in my sidebar.

Is the user loginout plugin going to be updated to match the new form methods?

sbillard

Check you theme files. This message should only happen if the theme contains a `password_form.php` script.

micheall

I verified this already. As I said, the error is being generated by the user_login-out.php file as it shows in the error message above:

PHP Notice: printPasswordForm (called from user_login-out.php line 116)

Going to http://inthemdl.net/page/password generates the error as well, including using the default zenpage theme.

The problem is the default password.php file in zenpage theme, and the printPasswordForm() call in user_login-out.php are in the 5/16 trunk build. I'll check the trunk from 5/18 once it's uploaded to night to verify.

sbillard

So, I say again, this error CAN ONLY OCCUR IF THERE IS A SCRIPT NAMED `password_form.php` in the theme folder. That is what the message is telling you--those theme forms are deprecated as they are not needed and most likely do not support the capabilities provided by for instance, the federated logon plugin.

Here is the code which produces the error:
`
$passwordform = SERVERPATH.'/'.THEMEFOLDER.'/'.$theme.'/password_form.php';
if (file_exists($passwordform)) {
deprecated_function_notify(gettext('printPasswordForm custom theme password forms is deprecated. You should style the form created by the Zenphoto_Authority class (or its derivatives) instead. Use of these forms will prevent alternative credentials implementations from working with a theme.'));

include($passwordform);
} else {
$_zp_authority->printLoginForm($_password_redirect, false, $_password_showuser, false, $_password_hint);
}
`
Note carefully the test it makes for a script named `password_form.php` residing in the theme folders. Of course any call on `printPasswordForm()` from a theme with such a file will cause the error. Zenpage on 1.4.1 DOES NOT have such a file. You can convince yourself of this by a) looking in the theme folder of the SVN/Nightly build. b) looking in the package list for such a file. `password_form.php` does not exist anywhere in the 1.4.1 release! Setup will complain if it should find a copy.

Vivian

I have that error to, i used theme zpardoise and that has a password_form.ph

How can I fix the error?

acrylian

My collegue tells it right above:

So, I say again, this error CAN ONLY OCCUR IF THERE IS A SCRIPT NAMED password_form.php in the theme folder. That is what the message is telling you--those theme forms are deprecated as they are not needed and most likely do not support the capabilities provided by for instance, the federated logon plugin.

In short: that file is not needed anymore. Delete it. Hopefully the theme developer will update the theme sometime.

Vivian

Ok, I deleted it, but now I have another problem: I login to the protected file
but stays on that page
try
http://www.michel-nulens.be/zenphoto/allerlei/

login
ikke
password
ikke

Vivian

I an't also login in the admin with the second user (only the admin)

acrylian

Login works fine for me using Safari. That password.php page should not be related to the admin login. Please try a standard theme.

Vivian

i tried chrome and explorer
I choosed another theme
but I see still the other theme?

acrylian

You need to clear the html cache naturally to see an effect.

Vivian

Ok I did, other theme is visible, but login still not working

acrylian

Try the standard login path www.domain.com/admin

Laurent

It's works with firefox but i have access without login ?

Also you only use 4 caracters for your password ?

You should read `http://en.wikipedia.org/wiki/Password_strength`
ZenPhoto can use a strong password with the password group.

Vivian

for admin login: I recreate the user, that works

for http://www.michel-nulens.be/zenphoto/allerlei/test/

login ikke
password ikke

still don't work

tested in google chrome and explorer
I purged the html cache

Vivian

@Laurent: admin password has 8 characters including an underscore

problem is the login for an album

acrylian

Now it does not work for me as well. Try to set the password again.

Vivian

i did: try again

Laurent

No password for me :-(

Vivian

i set a new regular login:
username: misterx
password: mister_1234

still don't work for me

is it working for anybody else?

Vivian

ok, there bust be an error in the userlogin page

this work:
http://www.michel-nulens.be/zenphoto/index.php?userlog=1&password=mister_1234 (I hand coded it)

this is the url when I tried to login 1 time:
http://www.michel-nulens.be/zenphoto/index.php?userlog=1&p=password#

do you see the difference?

acrylian

I have no idea. Sadly my collegue sbillard who is the expert on login stuff is away for a week.

In the meantime please review your server error log and also the debug log within /zp-data of your install.

sbillard

So are you tryig to provide the password as a query parameter to the form? That will simply not work. Password forms require the data to be Posted.