Flickerd 1.0.0 Finally Uploaded

amereservant

Hey everyone,
I am happy to be able to announce that Flickerd, a major rewrite of the Flickrish theme, is finally ready to share!

I've spent several hours over the past week on this project, updating the code, implementing new features, and converting it to HTML5.

Check it out at https://github.com/amereservant/FlickerdTheme and let me know what you think. Be sure to name the theme directory to flickerd since GitHub gives it a funny name.

TODO:

• I'm still working on adding the Google Maps plugin to it so photos that are geo-tagged will display a "View Map" option.
• I will hopefully add ZenPages to the theme soon so users can utilize that feature.
• Add Modernizr - This will allow for usage of CSS3 properties for browsers that support it and I will pretty it up some more.

I wish I could've added all of these, but I needed to get a usable version finished and then work on adding additional features, otherwise it'd be in development forever.

Special thanks to Stephen (sbillard) for his help! Since this is my first time using and theming ZenPhoto, I couldn't have done it without his help!

acrylian

New themes are very welcome. So is this actually a replacement of the flickrish theme looking the same? Just asking so I know how we should add this to the themes section. Probably as a separate entry anyway.

Would be great if you one time could add Zenpage support as well.
EDIT: I see it already has

(btw, it is "Zenphoto", not "ZenPhoto"..;-))

acrylian

I tried your theme locally to generate screenshots for the themes section and there is a problem with the CSS loading:
http://zenphoto.maltem.de/Test/Flickerd.jpg.php

[22-May-2011 11:28:39] PHP Notice: Zenphoto processed a 404 error on /zp-trunk/themes//css/stylesheet.css. See the debug log for details. in /Volumes/Daten/Grafik/zhtdocs/zp-trunk/zp-core/functions.php on line 2189

micheall

Looks good to me acrylian. I initially put it in a "flickered" directory like he said and then thought that might have been why it worked for me. So then I moved it to a randomnamed theme folder and it worked from there too.

Tested against 1.4.1-BETA [7304] with the theme's zip archive.

Looks great for being a flickr-inspired theme. Definitely agree that you need to work zenpage in to it.

acrylian

Well, I named the folder "flickerd"which is then wrong (although the class is named the same). But I think that should not really matter how the theme folder is named.

micheall

yeah, like I said when I initially set it up it was with the incorrect name (I had an extra e). But it all appeared to work. Did you use the gz file or the zip file?

sbillard

Do not forget that the 404 error acrylian reports will only show up in an SVN install. reporting 404 errors is part of our standard debug settings, supressed with nightly builds, etc.

You can enable the report by changing the DEBUG_404 define.

amereservant

So is this actually a replacement of the flickrish theme looking the same?

I actually started off of their code for an example, but it is a major rewrite to their theme with slight design changes and differences in functionality.
So as far as looks go, it looks similar, but it's a pretty substantial derivative to the Flickrish theme.

tried your theme locally to generate screenshots for the themes section and there is a problem with the CSS loading:

The problem is in your link URL. /zp-trunk/themes//css/stylesheet.css. The theme name is missing, which it is formed from the following code:
`


$css_dir = 'css/';

$css_url = WEBPATH.'/'. THEMEFOLDER .'/' .getOption('current_theme') .'/'. $css_dir;

`
So the problem seems to be with the return value of `getOption('current_theme')`...

I can't use $_zp_themeroot because it's not defined in time for when the URL must be determined. Not sure if this is just a bug on your end or if this is a bug in general that I need to find another way around. Any suggestions would be great if there's a better way to form the webpath to the theme, but it seems like I found that being how $_zp_themeroot was getting it's value and I copied it. Many late nights on this one, so I could be wrong.

Would be great if you one time could add Zenpage support as well.
EDIT: I see it already has

I am using the Zenpage plugin just for shortening the content in the thumbnail view, which it uses a single function from it. However, once I get the initial bugs worked out, I plan to add full Zenpage integration so users can use them on their photo sites.
I was trying to get the theme to a basic usable version first...

acrylian

I saw that the theme folder name is missing in the URL, I have not looked at your theme in detail but generally the theme folder should really not matter and fetched automatically via the `$_zp_themeroot`. I don't remember that we or anyone ever encountered this before. Where is that call in question?

Regarding full Zenpage support. Sure, was just a suggestion or wish but it is of course your choice as the themes author what plugins to support at all.

sbillard

$_zp_theme_root is setup when the theme is setup, so I do not see how it could not be defined when the them is running. Do you perchance reference it within a function without declaring it global?

amereservant

@sbillard,
That was the problem! I forgot to declare $_zp_themeroot as a global before calling it and therefore it had a null value.

Thanks.

acrylian

Keep in mind for further work that all of Zenphoto's globals start with `$_zp_(....)`.

acrylian

Just tried it again to generate screenshots for the theme's entry. Looks generally fine.

A few things I noticed:
It seems the image stream ignores if images are from an unpublished album or a subalbum of that. By Zenphoto's standards all childs (and their contents) of an unpublished parent are also considered unpublished even if they itself are not. Same of course regarding password or other protection.

You might also want to look at the display of default thumbs for multimedia items.

I never used flickr but find confusing on the "all sizes" page that there is no link to get back to the album you are in.

amereservant

Hey acrylian,
It *shouldn't* ignore unpublished albums unless the database field albums.show isn't what determines if an album is published or not.

I copied most of the query code used for retrieving the items from the image_album_statistics.php function `getImageStatistic()`.
The best I can tell, that function doesn't test for parent album permissions either, which is why I missed it.
I will try to get that corrected ASAP, as all I tested for was that password protected albums and images remain hidden and I know that much does work correctly.

I haven't gotten to multimedia items and had no intention on using them myself, but I will indeed get the default thumb added for those just so the theme is complete.

Regarding the back button ... Flickr actually doesn't have a back link either, which I looked into when I realized the same thing you did. That was what kept me from adding it, but I guess I can add one. I'm guessing it's assumed people know to click the back button, sorta like the target attribute was going to be scratched on anchor links because it was assumed the user should choose if it opens in a new window/tab and not up to the designer.

Anyways, I'll work on fixing those. Thanks for pointing those out.

acrylian

My point was that it showed images from unpublished albums. The image_album_stats to my knowledge never did that (well I co wrote that damm thing..;-)). Some of the checks have been reworked for 1.4.1 though if I recall right.

Regarding the back link. Of course if you arrived on that page via the album itself you can use the browser back button, but - not sure if that is possible with that theme - arrive directly via Google or else on that page there will be no other back anywhere. You don't even know from what album that images is. I absolutly agree on not using "target" for a new window (but some "normal users" don't know or use this at all, be assured...)

amereservant

Hey acrylian,
The unpublished albums issue actually is a problem with ZenPhoto.

When I unpublish an album, but then directly access the album via it's URL, the unpublished album is still viewable. It doesn't show in the Gallery home page, but the album is not blocked from a viewer directly linking to it and seeing the images.

For example, say I have a gallery named sample and I unpublish this album on my website http://mygallery.com, it will not show up when I go to http://mygallery.com.

However, if I go to http://mygallery.com/sample, regardless if I'm logged in or not, it will still show me that gallery's contents.

So therefore since the Flickerd theme relies on the core functionality of ZenPhoto to determine what photos are viewable and which ones aren't, this goes beyond the scope of the theme.

EDIT: This behavior was consistent when tried even with the default ZenPhoto theme.

acrylian

No, that is no issue but meant behaviour (since "forever"). Unpublished albums (as images, Zenpage pages and articles and with 1.4.1 even categories) are accessibe if you know the direct link. But it will not be shown anywhere unless you are logged in with the appropiate rights.
http://www.zenphoto.org/news/troubleshooting-guide#troubleshooting-security

So if you want your theme to be consistent your flickr image loop should NOT display images from unpublished albums (this includes all childs of an unpublished album and its images naturally). The 1.4.1 beta will introduce a new class method (checkAccess if I remember right offhand) to make these checks easier. See the function getImageAlbumAlbumList() of the image_album_statistics plugin there.

busternutley

Love this Flickerd theme. I've got an inquiry, geared more towards amereservant. Is it possible to set exact dimensions of the thumbnails in the photostream without distorting the photo? Right now my thumbnails are displayed in varying sizes because of the orientation of the original photo. I'm looking to make the layout of the photostream more modular (i.e., each thumbnail is 300x200 regardless of orientation).
I understand this is not how Flickr does it... just wondering if it's an option you'd consider putting into the next release of Flickerd.