issue with i-feel-dirty : I need help!

vincent3569 Member, Translator
edited September 2017 in Themes

hi,
I try to update my i-feel-dirty theme on github to be compliant with latetest zenphoto improvement (1.4.14).

All works great, but I have a strange issue that I am unable to fix.

If somebody can help me, I will apprecate!

see the demo:
http://demo.vincentbourganel.fr/?themeSwitcher=i-feel-dirty&cmsSwitch=true

see the issue:
https://github.com/vincent3569/i-feel-dirty/issues/5

you can download the latest code here: https://github.com/vincent3569/i-feel-dirty/archive/master.zip
and let me know if you found a fix

thanks to community

Comments

  • acrylian Administrator, Developer
    edited September 2017

    I assume that's the normal page menu function from Zenpage? So it must be something with the theme itself since it works with the Zenpage theme on the same install (edited my post as I thought you have only our themes for switching there).

  • acrylian Administrator, Developer
    edited September 2017

    I get this error on every page: Cannot modify header information - headers already sent by (output started at …/themes/i-feel-dirty/functions.php:16) in …/zp-core/index.php on line 128

    Additonally I see something like nonecheckForPage0$_ifeeldirty_homepage on top of the pages.

    No idea where this is coming from.

    Sidenote: if (!$_zenpage_and_news_enabled) die();.

    Don't do this! Redirect to the 404 page instead. Users will get a blank page otherwise and should really get a 404 message here.

  • acrylian Administrator, Developer
    edited September 2017

    The note on top of the pages comes from your functions.php. Probably just forgotten debug code?

  • acrylian Administrator, Developer

    Sorry, I have no idea right now what your theme is doing wrong here. pages.php is loaded but no page context.

  • acrylian Administrator, Developer

    It's your check in the theme's index.php. Just do it like the Zenpage theme does it right on index.php and not within functions.php. Then home page and normal pages work again.

  • vincent3569 Member, Translator

    Yes!
    you are right: when the check does only with indx.php and not within fnction.php, it works!

    thanks for you help!!

    btx, I rewrite some pages to manage 404 error

Sign In or Register to comment.